From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Thu, 17 May 2007 06:24:33 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179372282 10045 80.91.229.12 (17 May 2007 03:24:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 03:24:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 05:24:40 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HoWbV-0002J9-AI for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 05:24:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoWjW-0007UW-V9 for ged-emacs-devel@m.gmane.org; Wed, 16 May 2007 23:32:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HoWjU-0007UH-BD for emacs-devel@gnu.org; Wed, 16 May 2007 23:32:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HoWjT-0007U3-QJ for emacs-devel@gnu.org; Wed, 16 May 2007 23:32:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoWjT-0007U0-Mu for emacs-devel@gnu.org; Wed, 16 May 2007 23:32:51 -0400 Original-Received: from nitzan.inter.net.il ([213.8.233.22]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HoWbP-0007Py-PU for emacs-devel@gnu.org; Wed, 16 May 2007 23:24:32 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-151-141.inter.net.il [80.230.151.141]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id GTK75969 (AUTH halo1); Thu, 17 May 2007 06:24:32 +0300 (IDT) In-reply-to: <17995.31640.399794.621018@kahikatea.snap.net.nz> (message from Nick Roberts on Thu, 17 May 2007 09:46:00 +1200) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71207 Archived-At: > From: Nick Roberts > Date: Thu, 17 May 2007 09:46:00 +1200 > Cc: emacs-devel@gnu.org > > I can't easily add an extra argument to write_glyphs as it's called in many > places. But it sounds like all of them but one should be called with that argument zero, so it shouldn't be too hard to convert them. Am I missing something? > Do you mean something like below? (I've tested it and it works too.) It's > certainly more lightweght, but I think global variables tend to spoil the flow. Yes, that's what I had in mind. But isn't it equivalent to calling write_glyphs with the additional flag argument non-zero in just this one place? That would eliminate the need for a global variable.