From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Emacs-unicode-2: w32_font_match Date: Tue, 02 Nov 2004 08:54:50 +0000 Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099385860 5295 80.91.229.6 (2 Nov 2004 08:57:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2004 08:57:40 +0000 (UTC) Cc: emacs-devel@gnu.org, Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 02 09:57:34 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1COuTt-0001sU-00 for ; Tue, 02 Nov 2004 09:57:34 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COubw-0002ep-2V for ged-emacs-devel@m.gmane.org; Tue, 02 Nov 2004 04:05:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COuap-0002SM-3p for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COual-0002R2-V9 for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COuak-0002Qb-Ft for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:39 -0500 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1COuRg-0006nJ-Ru for emacs-devel@gnu.org; Tue, 02 Nov 2004 03:55:17 -0500 Original-Received: from wanchan.jasonrumney.net (i-195-137-77-250.freedom2surf.net [195.137.77.250]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id iA28tBnF003028; Tue, 2 Nov 2004 08:55:11 GMT Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id C42F4DDD3A; Tue, 2 Nov 2004 08:55:09 +0000 (GMT) Original-To: KOBAYASHI Yasuhiro In-Reply-To: (KOBAYASHI Yasuhiro's message of "Tue, 02 Nov 2004 15:09:58 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29296 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29296 KOBAYASHI Yasuhiro writes: > The attached patch use fast_string_match for comparing > font names. Thank you, I installed it. - return (fast_c_string_match_ignore_case (build_string (regex), - font_name_copy) >= 0); + return (fast_string_match_ignore_case (build_string (regex), + build_string (fontname)) >= 0); Shouldn't that last line be "build_string (font_name_copy)) >= 0);"? Otherwise you create font_name_copy, modify it, then never use it.