From: Jason Rumney <jasonr@gnu.org>
Cc: emacs-devel@gnu.org, Kenichi Handa <handa@m17n.org>
Subject: Re: Emacs-unicode-2: w32_font_match
Date: Tue, 02 Nov 2004 08:54:50 +0000 [thread overview]
Message-ID: <uwtx43a1x.fsf@jasonrumney.net> (raw)
In-Reply-To: <uk6t47pe1.fsf@otsukakj.co.jp> (KOBAYASHI Yasuhiro's message of "Tue, 02 Nov 2004 15:09:58 +0900")
KOBAYASHI Yasuhiro <kobayays@otsukakj.co.jp> writes:
> The attached patch use fast_string_match for comparing
> font names.
Thank you, I installed it.
- return (fast_c_string_match_ignore_case (build_string (regex),
- font_name_copy) >= 0);
+ return (fast_string_match_ignore_case (build_string (regex),
+ build_string (fontname)) >= 0);
Shouldn't that last line be "build_string (font_name_copy)) >= 0);"?
Otherwise you create font_name_copy, modify it, then never use it.
prev parent reply other threads:[~2004-11-02 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 6:09 Emacs-unicode-2: w32_font_match KOBAYASHI Yasuhiro
2004-11-02 8:54 ` Jason Rumney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwtx43a1x.fsf@jasonrumney.net \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@m17n.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).