From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sridhar Boovaraghavan Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Thu, 04 Oct 2007 14:03:34 -0400 Message-ID: References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191526481 6285 80.91.229.12 (4 Oct 2007 19:34:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Oct 2007 19:34:41 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 04 21:34:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdWSb-0004R7-LX for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 21:34:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdWST-0008BQ-0K for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 15:34:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdWSP-0008B7-Ug for emacs-devel@gnu.org; Thu, 04 Oct 2007 15:34:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdWSH-00087p-9d for emacs-devel@gnu.org; Thu, 04 Oct 2007 15:34:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdWSH-00087m-3d for emacs-devel@gnu.org; Thu, 04 Oct 2007 15:33:53 -0400 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IdWSB-0005Nf-LW for emacs-devel@gnu.org; Thu, 04 Oct 2007 15:33:52 -0400 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IdW0X-0000t3-2E for emacs-devel@gnu.org; Thu, 04 Oct 2007 19:05:13 +0000 Original-Received: from ool-4356a48d.dyn.optonline.net ([67.86.164.141]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Oct 2007 19:05:13 +0000 Original-Received: from sridhar_ml by ool-4356a48d.dyn.optonline.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Oct 2007 19:05:13 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 89 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: ool-4356a48d.dyn.optonline.net User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (windows-nt) Cancel-Lock: sha1:TmYH7thO459YF6JcQw+doza+oG0= X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80249 Archived-At: Thank you for looking into and diagnosing the problem. I have moved the inclusion of above "lisp.h" in the affected files and here's a patch against HEAD that solves this issue. Regards, Sridhar -- Index: data.c =================================================================== RCS file: /sources/emacs/emacs/src/data.c,v retrieving revision 1.278 diff -r1.278 data.c 26,33d25 < #include "lisp.h" < #include "puresize.h" < #include "charset.h" < #include "buffer.h" < #include "keyboard.h" < #include "frame.h" < #include "syssignal.h" < #include "termhooks.h" /* For FRAME_KBOARD reference in y-or-n-p. */ 64a57,65 > #include "lisp.h" > #include "puresize.h" > #include "charset.h" > #include "buffer.h" > #include "keyboard.h" > #include "frame.h" > #include "syssignal.h" > #include "termhooks.h" /* For FRAME_KBOARD reference in y-or-n-p. */ > Index: floatfns.c =================================================================== RCS file: /sources/emacs/emacs/src/floatfns.c,v retrieving revision 1.95 diff -r1.95 floatfns.c 50,51d49 < #include "lisp.h" < #include "syssignal.h" 78a77,79 > #include "lisp.h" > #include "syssignal.h" > Index: lread.c =================================================================== RCS file: /sources/emacs/emacs/src/lread.c,v retrieving revision 1.380 diff -r1.380 lread.c 30a31 > #include 62,63d62 < #include < Index: print.c =================================================================== RCS file: /sources/emacs/emacs/src/print.c,v retrieving revision 1.240 diff -r1.240 print.c 25a26,38 > > /* Work around a problem that happens because math.h on hpux 7 > defines two static variables--which, in Emacs, are not really static, > because `static' is defined as nothing. The problem is that they are > defined both here and in lread.c. > These macros prevent the name conflict. */ > #if defined (HPUX) && !defined (HPUX8) > #define _MAXLDBL print_maxldbl > #define _NMAXLDBL print_nmaxldbl > #endif > > #include > 48,59d60 < /* Work around a problem that happens because math.h on hpux 7 < defines two static variables--which, in Emacs, are not really static, < because `static' is defined as nothing. The problem is that they are < defined both here and in lread.c. < These macros prevent the name conflict. */ < #if defined (HPUX) && !defined (HPUX8) < #define _MAXLDBL print_maxldbl < #define _NMAXLDBL print_nmaxldbl < #endif < < #include < -- Sridhar Boovaraghavan