From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Re: Change in compile.el
Date: 17 Feb 2004 07:59:43 +0200
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <uvfm62qls.fsf@elta.co.il>
References: <jwvk72mddyh.fsf-monnier+emacs/devel@asado.iro.umontreal.ca>
Reply-To: Eli Zaretskii <eliz@elta.co.il>
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1076998086 27826 80.91.224.253 (17 Feb 2004 06:08:06 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Tue, 17 Feb 2004 06:08:06 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Feb 17 07:07:59 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AsyOl-0004c6-00
	for <emacs-devel@deer.gmane.org>; Tue, 17 Feb 2004 07:07:59 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1AsyOk-0003Zp-00
	for <emacs-devel@quimby.gnus.org>; Tue, 17 Feb 2004 07:07:58 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.24)
	id 1AsyGX-0000bt-6Z
	for emacs-devel@quimby.gnus.org; Tue, 17 Feb 2004 00:59:29 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1AsyFs-0000Zw-SW
	for emacs-devel@gnu.org; Tue, 17 Feb 2004 00:58:48 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1AsyFC-0000VZ-5H
	for emacs-devel@gnu.org; Tue, 17 Feb 2004 00:58:37 -0500
Original-Received: from [207.232.27.5] (helo=WST0054)
	by monty-python.gnu.org with asmtp (Exim 4.24)
	id 1AsyFB-0000VT-6Z; Tue, 17 Feb 2004 00:58:05 -0500
Original-To: Stefan Monnier <monnier@iro.umontreal.ca>
In-reply-to: <jwvk72mddyh.fsf-monnier+emacs/devel@asado.iro.umontreal.ca>
	(message from Stefan Monnier on 16 Feb 2004 15:08:48 -0500)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Emacs development discussions.  <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:20011
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20011

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: 16 Feb 2004 15:08:48 -0500
> 
> 2004-02-16  Alfred M. Szmidt  <ams@kemisten.nu>  (tiny change)
> 
> 	* progmodes/compile.el (compilation-directory): New defvar.
> 	(compile): Save current directory in compilation-directory.
> 	(recompile): Bind default-directory to compilation-directory if
> 	that is non-nil.
> 
> Has somebody tested this change?

Richard asked me to commit this.  I didn't test it, just proofread it.

> I.e. it breaks in those cases where the old code did the right thing
> (i.e. when you go to a compile-mode buffer and do `recompile' there).

Feel free to fix the code so that this special case isn't broken, or
even take out this change entirely if you think it does more harm than
good.

> PS: Also, would it be possible to try and refrain from changing compile.el
> until the newer version is installed?

How is one supposed to know that a new version is in the works?  We
don't really have a machinery for approving patches, so there's no
good way to coordinate patches.