unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Kenichi Handa <handa@m17n.org>
Cc: dann@ics.uci.edu, kifer@cs.sunysb.edu, emacs-devel@gnu.org
Subject: Re: ediff and coding systems
Date: Mon, 22 Oct 2007 06:20:15 +0200	[thread overview]
Message-ID: <uve8zu6f4.fsf@gnu.org> (raw)
In-Reply-To: <E1IjoBj-0004LS-Pe@etlken.m17n.org> (message from Kenichi Handa on Mon, 22 Oct 2007 12:42:47 +0900)

> From: Kenichi Handa <handa@m17n.org>
> CC: kifer@cs.sunysb.edu, eliz@gnu.org, emacs-devel@gnu.org
> Date: Mon, 22 Oct 2007 12:42:47 +0900
> 
>   read-coding-system("Select coding system (default mule-utf-8): " mule-utf-8)
>   select-safe-coding-system-interactively(1 5557 (utf-8 ....))
>   select-safe-coding-system(1 5557 nil nil "/tmp/fineDiffA155544eB")
>   write-region(1 5557 "/tmp/fineDiffA155544eB" nil no-message)
>   ediff-make-temp-file(#<buffer  *ediff-tmp*> "fineDiffA" "/tmp/fineDiffA155544eB")
>   ediff-make-fine-diffs(5 noforce)
>   ediff-install-fine-diff-if-necessary(5)
>   ediff-next-difference(1)
>   call-interactively(ediff-next-difference)
> 
> I don't know why ediff-make-temp-file is called, but perhaps
> it should call write-region while binding
> coding-system-for-write to `no-conversion' or `emacs-mule'.

Not a good idea, I'm afraid: those temporary files (or parts thereof)
will need to be read back, when `diff' finishes, so each one needs to
be in the original encoding, or else the diffs will be incorrect.
E.g., imagine two files with the same text, but different encodings: I
don't think we want ediff say that they compare identical.

  reply	other threads:[~2007-10-22  4:20 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20 15:21 ediff and coding systems Dan Nicolaescu
2007-10-20 18:09 ` Eli Zaretskii
2007-10-21  5:43   ` Michael Kifer
2007-10-21  6:12     ` Dan Nicolaescu
2007-10-21  6:52       ` Michael Kifer
2007-10-21  7:17         ` Dan Nicolaescu
2007-10-21 18:46           ` Michael Kifer
2007-10-21 19:22             ` Dan Nicolaescu
2007-10-21 19:37               ` Leo
2007-10-21 21:35               ` Michael Kifer
2007-10-22  2:08                 ` Dan Nicolaescu
2007-10-22  3:50                   ` Michael Kifer
2007-10-27 21:03                     ` Dan Nicolaescu
2007-10-28 21:01                       ` Michael Kifer
2007-10-22  3:42               ` Kenichi Handa
2007-10-22  4:20                 ` Eli Zaretskii [this message]
2007-10-22  5:05                   ` Kenichi Handa
2007-10-22 15:32                   ` Stefan Monnier
2007-10-22 21:11                     ` Eli Zaretskii
2007-10-22  4:29                 ` Michael Kifer
2007-10-22 15:34                   ` Stefan Monnier
2007-10-22 16:18                     ` Michael Kifer
2007-10-21  2:12 ` Stefan Monnier
2007-10-21  2:43   ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uve8zu6f4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=handa@m17n.org \
    --cc=kifer@cs.sunysb.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).