Whitespace in mode line of 29.1-rc1 emacsclient frames

Whitespace in mode line of 29.1-rc1 emacsclient frames

[Ulrich Mueller]

With Emacs 28.2 the mode line used to look like this for an emacsclient
frame (e.g. for the *scratch* buffer):

U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)

With Emacs 29.1-rc1 I get:

U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)

Especially I wonder about the whitespace between : and @ close to the
beginning of the line.

Looks like it originates from (min-width (5.0)) in mode-line-position?

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Ulrich Mueller]

>>>>> On Thu, 27 Jul 2023, Ulrich Mueller wrote:

> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):

> U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)

> With Emacs 29.1-rc1 I get:

> U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)

> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.

> Looks like it originates from (min-width (5.0)) in mode-line-position?

Sorry, I meant standard-mode-line-format.

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Visuwesh]

[வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:

> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):
>
> U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)
>
> With Emacs 29.1-rc1 I get:
>
> U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)
>
> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.
>
> Looks like it originates from (min-width (5.0)) in mode-line-position?

Yes.  See bug#58183 [1].  I see this too but cannot reproduce it
reliably.  Unfortunately, I didn't have enough time recently to look
deeply into this issue.
FWIW, this issue goes away if you set mode-line-compact which is why it
took me a long time to notice.

1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Ulrich Mueller]

>>>>> On Thu, 27 Jul 2023, Visuwesh  wrote:

> [வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:
>> With Emacs 28.2 the mode line used to look like this for an emacsclient
>> frame (e.g. for the *scratch* buffer):
>> 
>> U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)
>> 
>> With Emacs 29.1-rc1 I get:
>> 
>> U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)
>> 
>> Especially I wonder about the whitespace between : and @ close to the
>> beginning of the line.

>> Looks like it originates from (min-width (5.0)) in mode-line-position
>> [correction: standard-mode-line-format]?

> Yes.  See bug#58183 [1].  I see this too but cannot reproduce it
> reliably.  Unfortunately, I didn't have enough time recently to look
> deeply into this issue.
> FWIW, this issue goes away if you set mode-line-compact which is why it
> took me a long time to notice.

> 1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/

Thank you very much! I wasn't aware that mode-line-compact exists.

Still, min-width should probably apply to the whole U:@--- string, not
to individual characters of it?

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Visuwesh]

[வியாழன் ஜூலை 27, 2023] Ulrich Mueller wrote:

>>> U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)
>>> 
>>> With Emacs 29.1-rc1 I get:
>>> 
>>> U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)
>>> 
>>> [...]
>> Yes.  See bug#58183 [1].  I see this too but cannot reproduce it
>> reliably.  Unfortunately, I didn't have enough time recently to look
>> deeply into this issue.
>> FWIW, this issue goes away if you set mode-line-compact which is why it
>> took me a long time to notice.
>
>> 1. https://yhetil.org/emacs-bugs/87r0ztuaj5.fsf@miha-pc/
>
> Thank you very much! I wasn't aware that mode-line-compact exists.

You do lose out on being able to click on minor and major modes listed
in the mode-line to bring up the menus, see bug#64650 [1].  But this was
fixed recently on master.

> Still, min-width should probably apply to the whole U:@--- string, not
> to individual characters of it?

AFAIU, the idea was to make all the individual characters easily
clickable when the mode-line uses a variable-pitch font which is why
each character has the property.

1. https://yhetil.org/emacs-bugs/E4CLAcF9C1bzg1OPj7GPgdqBLKWtJhlVhwgq9gZkXF_TY9zgPi4LvG8y9SQ3IrOboBRltqUcQ5gGQxSf5DK0sz7lE5l__Mb7fyNp-WwgHes=@proton.me/

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Ulrich Mueller]

>>>>> On Thu, 27 Jul 2023, Visuwesh  wrote:

>> Still, min-width should probably apply to the whole U:@--- string, not
>> to individual characters of it?

> AFAIU, the idea was to make all the individual characters easily
> clickable when the mode-line uses a variable-pitch font which is why
> each character has the property.

Then again, the "U", the ":" and the three "-" are all single chars,
so why should the "@" be wider? This looks like a bug to me.

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Eli Zaretskii]

> From: Ulrich Mueller <ulm@gentoo.org>
> Date: Thu, 27 Jul 2023 12:55:59 +0200
> 
> With Emacs 28.2 the mode line used to look like this for an emacsclient
> frame (e.g. for the *scratch* buffer):
> 
> U:@---  *scratch*      All L4     (Lisp Interaction ElDoc)
> 
> With Emacs 29.1-rc1 I get:
> 
> U:   @---    *scratch*      All   L4     (Lisp Interaction ElDoc)
> 
> Especially I wonder about the whitespace between : and @ close to the
> beginning of the line.

This was done on purpose, so that people could use proportional font
for the mode-line face.

Why is that a problem?

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Eli Zaretskii]

> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 27 Jul 2023 13:40:46 +0200
> 
> Still, min-width should probably apply to the whole U:@--- string, not
> to individual characters of it?

Where do you see it applied to individual characters?  I see this in
bindings.el:

             (list
              :propertize
              (list ""
	            'mode-line-mule-info
	            'mode-line-client
	            'mode-line-modified
	            'mode-line-remote)
              'display '(min-width (5.0)))

Re: Whitespace in mode line of 29.1-rc1 emacsclient frames

[Ulrich Mueller]

>>>>> On Thu, 27 Jul 2023, Eli Zaretskii wrote:

>> From: Ulrich Mueller <ulm@gentoo.org>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 27 Jul 2023 13:40:46 +0200
>> 
>> Still, min-width should probably apply to the whole U:@--- string, not
>> to individual characters of it?

> Where do you see it applied to individual characters?  I see this in
> bindings.el:

>              (list
>               :propertize
>               (list ""
> 	            'mode-line-mule-info
> 	            'mode-line-client
> 	            'mode-line-modified
> 	            'mode-line-remote)
>               'display '(min-width (5.0)))

Then why does it insert whitespace between mode-line-mule-info and
mode-line-client?