From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [hober0@gmail.com: Re: mode-line redisplay bug] Date: Tue, 11 Oct 2005 11:47:09 +0100 Message-ID: References: <46247494-627E-4DE6-892E-57AAF7C70E1C@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1129029333 22583 80.91.229.2 (11 Oct 2005 11:15:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 Oct 2005 11:15:33 +0000 (UTC) Cc: "Jan D." , rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 11 13:15:31 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EPI4l-0002Ts-Ey for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 13:13:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPI4k-0006HM-Ox for ged-emacs-devel@m.gmane.org; Tue, 11 Oct 2005 07:13:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EPHgW-0007vL-MX for emacs-devel@gnu.org; Tue, 11 Oct 2005 06:48:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EPHgU-0007uh-34 for emacs-devel@gnu.org; Tue, 11 Oct 2005 06:48:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EPHgT-0007uZ-Kn for emacs-devel@gnu.org; Tue, 11 Oct 2005 06:48:37 -0400 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1EPHgS-0001in-PR; Tue, 11 Oct 2005 06:48:37 -0400 Original-Received: from wanchan.jasonrumney.net (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id j9BAmZch002529; Tue, 11 Oct 2005 11:48:35 +0100 Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 5C4B55FB; Tue, 11 Oct 2005 11:48:35 +0100 (BST) Original-To: YAMAMOTO Mitsuharu In-Reply-To: (YAMAMOTO Mitsuharu's message of "Tue, 11 Oct 2005 10:21:33 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43861 Archived-At: YAMAMOTO Mitsuharu writes: > A simple debug code below shows the incorrectness of the calculated > rectangle :-). The debugging code you posted was for glyph_rect, which was not affected by my patch. But this does show that there are problems with all this code to detect mouse motion and throttle the movement events. You debugging code appears to highlight the glyph below the one the mouse is currently over. This if statement seems to be wrong: if (r->y >= y) Where y is the mouse position and r->y is the top of the glyph. If r->y > y, then we have already reached the glyph below the one we want. The only case where this works correctly is when the mouse pointer is over the top edge of the glyph so r->y == y. I think this needs to be: if (r->y + r->height > y) I will do some more testing, and check in the changes when I think I have got it right.