From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [jpw@pobox.com: crash setting frame parameter icon-name to non-nil non-string value] Date: Sat, 03 Jun 2006 00:23:24 +0300 Message-ID: References: <87irnjo6qz.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1149283430 28169 80.91.229.2 (2 Jun 2006 21:23:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Jun 2006 21:23:50 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 02 23:23:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FmH7L-0005ev-Bv for ged-emacs-devel@m.gmane.org; Fri, 02 Jun 2006 23:23:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FmH7K-0006A6-OA for ged-emacs-devel@m.gmane.org; Fri, 02 Jun 2006 17:23:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FmH79-00069s-0D for emacs-devel@gnu.org; Fri, 02 Jun 2006 17:23:27 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FmH76-00068i-DN for emacs-devel@gnu.org; Fri, 02 Jun 2006 17:23:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FmH76-00068J-8O for emacs-devel@gnu.org; Fri, 02 Jun 2006 17:23:24 -0400 Original-Received: from [192.114.186.20] (helo=nitzan.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FmHDe-00017C-At for emacs-devel@gnu.org; Fri, 02 Jun 2006 17:30:10 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-147-250.inter.net.il [80.230.147.250]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id DOG59492 (AUTH halo1); Sat, 3 Jun 2006 00:23:21 +0300 (IDT) Original-To: Chong Yidong In-reply-to: <87irnjo6qz.fsf@stupidchicken.com> (message from Chong Yidong on Fri, 02 Jun 2006 12:35:32 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55634 Archived-At: > From: Chong Yidong > Date: Fri, 02 Jun 2006 12:35:32 -0400 > Cc: emacs-devel@gnu.org > > I checked in another fix (patch below). Probably macfns.c and > w32fns.c need to be fixed too. The w32 port doesn't crash with such invalid values of the icon, because the code that uses f->icon_name is ifdef'ed away. But I installed the change in w32fns.c nonetheless, thanks for the heads up.