From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] autorevert.el -- revert fix for Windows platform Date: Fri, 23 Mar 2007 15:25:05 +0200 Message-ID: References: <7it9frhi.fsf@cante.net> <87slbx9vcf.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1174656329 8716 80.91.229.12 (23 Mar 2007 13:25:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 13:25:29 +0000 (UTC) Cc: emacs-devel@gnu.org, jari.aalto@cante.net To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 14:25:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUjlb-0000lq-8H for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 14:25:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUjnU-0004Tc-Ue for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 08:27:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUjnQ-0004Lj-CE for emacs-devel@gnu.org; Fri, 23 Mar 2007 09:27:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HUjnO-00049p-88 for emacs-devel@gnu.org; Fri, 23 Mar 2007 09:27:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUjnO-00049D-4I for emacs-devel@gnu.org; Fri, 23 Mar 2007 08:27:06 -0500 Original-Received: from nitzan.inter.net.il ([213.8.233.22]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HUjlT-0001LU-9d for emacs-devel@gnu.org; Fri, 23 Mar 2007 09:25:07 -0400 Original-Received: from HOME-C4E4A596F7 ([81.5.34.178]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id GJA65835 (AUTH halo1); Fri, 23 Mar 2007 15:25:03 +0200 (IST) In-reply-to: <87slbx9vcf.fsf@stupidchicken.com> (message from Chong Yidong on Thu, 22 Mar 2007 11:00:32 -0400) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68388 Archived-At: > From: Chong Yidong > Date: Thu, 22 Mar 2007 11:00:32 -0400 > Cc: emacs-devel@gnu.org > > Jari Aalto writes: > > > For some reason the `verify-visited-file-modtime' test in > > auto-revert-buffers is not enough to notice a file change under > > Windows / native Emacs 21.3. Here is patch to compare the bufer size > > against files size on disk. It cures the revert problem. > > That's not foolproof, since changes need not alter the file size. Right, it's certainly not a good idea to install such a kludgey solution.