From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Cursor in non-selected windows is 1 pixel too small Date: Sun, 05 Mar 2006 21:50:35 +0200 Message-ID: References: <44081767.4010004@iue.tuwien.ac.at> <44096641.8080505@iue.tuwien.ac.at> <44096CE7.9050202@iue.tuwien.ac.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1141588279 27428 80.91.229.2 (5 Mar 2006 19:51:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Mar 2006 19:51:19 +0000 (UTC) Cc: gritsch@iue.tuwien.ac.at, emacs-devel@gnu.org, storm@cua.dk Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 05 20:51:16 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FFzG7-00054d-Jk for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2006 20:51:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FFzGF-0007Dn-4m for ged-emacs-devel@m.gmane.org; Sun, 05 Mar 2006 14:51:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FFzFv-0005zw-MS for emacs-devel@gnu.org; Sun, 05 Mar 2006 14:51:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FFzFs-0005sS-4V for emacs-devel@gnu.org; Sun, 05 Mar 2006 14:51:03 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FFzFr-0005sE-UN for emacs-devel@gnu.org; Sun, 05 Mar 2006 14:50:59 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FFzHw-0008Dt-De for emacs-devel@gnu.org; Sun, 05 Mar 2006 14:53:09 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-84-228-166-152.inter.net.il [84.228.166.152]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DRO03241 (AUTH halo1); Sun, 5 Mar 2006 21:50:33 +0200 (IST) Original-To: YAMAMOTO Mitsuharu In-reply-to: (message from YAMAMOTO Mitsuharu on Sun, 05 Mar 2006 18:14:03 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51241 Archived-At: > Date: Sun, 05 Mar 2006 18:14:03 +0900 > From: YAMAMOTO Mitsuharu > Cc: Eli Zaretskii , > Markus Gritsch , emacs-devel@gnu.org > > The W32 port seems to have an adjustment for the cursor width in > get_phys_cursor_geometry: > > wd = glyph->pixel_width - 1; > #ifdef HAVE_NTGUI > wd++; /* Why? */ > #endif > > So, wherever we add adjustment, it should be done in a consistent way > between width and height, I think. I don't have an easy access to an X Windows platform for a moment. Can someone who has please verify positively that the hollow cursor in non-selected windows there is _exactly_ the same size in pixels as the solid block cursor in the selected window? I looked at the man pages of XDrawRectangle, and it sounds like it needs the same arguments as the MS-Windows FrameRect, so I wonder whether we simply missed this on all platforms.