From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Problem report #13 FALSE Date: Thu, 11 May 2006 10:40:52 +0100 Message-ID: References: <200604111549.k3BFnQ2N015126@scanner2.ics.uci.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1147340574 7450 80.91.229.2 (11 May 2006 09:42:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 May 2006 09:42:54 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 11 11:42:53 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fe7h3-0002nk-ES for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 11:42:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe7h2-0006Kc-PB for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 05:42:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fe7gq-0006Ih-1L for emacs-devel@gnu.org; Thu, 11 May 2006 05:42:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fe7gn-0006Fh-SU for emacs-devel@gnu.org; Thu, 11 May 2006 05:42:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fe7gn-0006FP-JD for emacs-devel@gnu.org; Thu, 11 May 2006 05:42:33 -0400 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fe7iH-0002NG-CC for emacs-devel@gnu.org; Thu, 11 May 2006 05:44:05 -0400 Original-Received: from wanchan.jasonrumney.net (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (Postfix) with ESMTP id 8D4E14C9E50; Thu, 11 May 2006 10:42:31 +0100 (BST) Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 5115A67; Thu, 11 May 2006 10:42:31 +0100 (BST) Original-To: Kenichi Handa In-Reply-To: (Kenichi Handa's message of "Thu, 11 May 2006 11:19:00 +0900") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54251 Archived-At: Kenichi Handa writes: >> Function: encode_coding_string >> Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a function that dereferences it. > > I see no bug here. A member of (coding)->cmp_data is > accessed only after checking (coding)->cmp_data is not NULL. > >> Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(coding)->cmp_data == 0" >> Also see events: [var_deref_model] >> At conditional (1): "(coding)->cmp_data == 0" taking true path > >> 6435 if (coding->type != coding_type_ccl >> 6436 && (! coding->cmp_data || coding->cmp_data->used == 0)) >> 6437 { > > Does the checker require it to be writen as below? > >> 6436 && (coding->cmp_data ? coding->cmp_data->used == 0 : 1)) I don't think so, as that is not the line it is complaining about. Rather the line: 6454 result = encode_coding (coding, SDATA (str) + from + consumed, 6455 buf.data + produced, to_byte - from - consumed, 6456 buf.size - produced); So the question is, 1. Do we reach that line when coding->cmp_data is NULL? 2. Does coding->cmp_data really get dereferenced inside encode_coding in the case where it is NULL? Judging by your previous responses to coding related problem reports, there is probably some other condition that always prevents both of these, but I don't understand enough about the coding structure to tell myself.