From: Jason Rumney <jasonr@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Problem report #13 FALSE
Date: Thu, 11 May 2006 10:40:52 +0100 [thread overview]
Message-ID: <uslng7vbv.fsf@jasonrumney.net> (raw)
In-Reply-To: <E1Fe0lY-0002QP-00@etlken> (Kenichi Handa's message of "Thu, 11 May 2006 11:19:00 +0900")
Kenichi Handa <handa@m17n.org> writes:
>> Function: encode_coding_string
>> Description: Variable "(coding)->cmp_data" tracked as NULL was passed to a function that dereferences it.
>
> I see no bug here. A member of (coding)->cmp_data is
> accessed only after checking (coding)->cmp_data is not NULL.
>
>> Event var_compare_op: Added "(coding)->cmp_data" due to comparison "(coding)->cmp_data == 0"
>> Also see events: [var_deref_model]
>> At conditional (1): "(coding)->cmp_data == 0" taking true path
>
>> 6435 if (coding->type != coding_type_ccl
>> 6436 && (! coding->cmp_data || coding->cmp_data->used == 0))
>> 6437 {
>
> Does the checker require it to be writen as below?
>
>> 6436 && (coding->cmp_data ? coding->cmp_data->used == 0 : 1))
I don't think so, as that is not the line it is complaining
about. Rather the line:
6454 result = encode_coding (coding, SDATA (str) + from + consumed,
6455 buf.data + produced, to_byte - from -
consumed,
6456 buf.size - produced);
So the question is,
1. Do we reach that line when coding->cmp_data is NULL?
2. Does coding->cmp_data really get dereferenced inside encode_coding
in the case where it is NULL?
Judging by your previous responses to coding related problem reports,
there is probably some other condition that always prevents both of
these, but I don't understand enough about the coding structure to
tell myself.
prev parent reply other threads:[~2006-05-11 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 15:49 Problem report #13 Dan Nicolaescu
2006-05-11 2:19 ` Problem report #13 FALSE Kenichi Handa
2006-05-11 2:46 ` Dan Nicolaescu
2006-05-11 9:30 ` Andreas Schwab
2006-05-11 10:58 ` Kenichi Handa
2006-05-11 9:40 ` Jason Rumney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uslng7vbv.fsf@jasonrumney.net \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).