From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: byte compiling defcustom Date: Sat, 17 Nov 2007 11:06:00 -0800 Message-ID: References: <200711171647.lAHGlHqH024027@jane.dms.auburn.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195326542 6021 80.91.229.12 (17 Nov 2007 19:09:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 17 Nov 2007 19:09:02 +0000 (UTC) Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca, rms@gnu.org To: Luc Teirlinck Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 17 20:09:07 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ItT2I-00040x-7l for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 20:08:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItT24-0007IG-W2 for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 14:08:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItT1S-0006PK-W4 for emacs-devel@gnu.org; Sat, 17 Nov 2007 14:08:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItT1S-0006Mi-7q for emacs-devel@gnu.org; Sat, 17 Nov 2007 14:08:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItT1R-0006MS-VN for emacs-devel@gnu.org; Sat, 17 Nov 2007 14:08:06 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItT1O-0007U0-Cd; Sat, 17 Nov 2007 14:08:02 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lAHJ609w010840; Sat, 17 Nov 2007 11:06:11 -0800 (PST) In-Reply-To: <200711171647.lAHGlHqH024027@jane.dms.auburn.edu> (Luc Teirlinck's message of "Sat, 17 Nov 2007 10:47:17 -0600 (CST)") Original-Lines: 30 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83466 Archived-At: Luc Teirlinck writes: > Stefan Monnier wrote: > > The patch below implements the desired feature: it byte-compiles the > default-value-expression (first part of the hunk) as well as any > keyword arguments (second part of the hunk) > > I did not try the patch, but I can not see how this would _not_ ruin > the "Show Saved Lisp Expression" feature in the State buttons in > Custom buffers by showing byte code instead of Lisp code that the user > can edit. Does it not? I wouldn't want to speculate, how can one check for that? I don't know how to use "Show Saved Lisp Expression", and it seems that the "Custom" menu in a customize buffer does not work, it disappears after touching the customize value, the same happens in 22.1... > FWIW the size of a tar file containing all the elc files in emacs went > from 29511680 to 29491200 after this patch. Not the best metric, but it > shows that the patch has some impact. > > I do not know whether the "some impact" above was meant seriously or > ironically, but the "impact" is less than 0.07 percent, that is, for > all practical purposes inexistent. Definitely not worth ruining a > feature for. Looking at the percentage of total space does not look like a valid comparison for this optimization that applies to a _very_ small subset of the whole codebase.