From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: C-x v v no longer works the way it used to Date: Tue, 13 Nov 2007 08:48:35 -0800 Message-ID: References: <87r6jxctcv.fsf@rho.meyering.net> <200710192321.l9JNLebF010003@oogie-boogie.ics.uci.edu> <20071020210750.GA7341@thyrsus.com> <200710210259.l9L2xo2x000826@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194972630 6723 80.91.229.12 (13 Nov 2007 16:50:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2007 16:50:30 +0000 (UTC) Cc: Emacs development discussions , Jim Meyering , Stefan Monnier To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 13 17:50:32 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Iryxd-0005AO-Ql for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2007 17:50:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IryxR-0001oR-2z for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2007 11:49:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IryxI-0001lm-F7 for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:49:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IryxH-0001lL-Jx for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:49:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IryxH-0001lG-FT for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:49:39 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IryxG-0007km-VH for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:49:39 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lADGmZgH005548; Tue, 13 Nov 2007 08:48:37 -0800 (PST) In-Reply-To: (Dan Nicolaescu's message of "Mon, 12 Nov 2007 07:32:50 -0800") Original-Lines: 47 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=1.185, required 5, autolearn=disabled, ALL_TRUSTED -1.44, FS_SINGLE_LETTER 1.00, GAPPY_SUBJECT 1.62) X-ICS-MailScanner-SpamScore: s X-ICS-MailScanner-From: dann@ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83133 Archived-At: Dan Nicolaescu writes: > Dan Nicolaescu writes: > > > "Eric S. Raymond" writes: > > > > > Dan Nicolaescu : > > > > This patch fixes it. > > > > vc-next-action still has the logic to deal with unregistered files, > > > > but vc-deduce-fileset would not return one... > > > > This patch is technically incorrect because it changes > > > > vc-deduce-fileset to not do what it's docs says it has to do. > > > > Not sure how the new VC design is supposed to work to fix it > > > > properly... > > > > > > You had the right general idea; the strategy has to go through > > > vc-deduce-fileset in order not to break the design. But your patch > > > produces behavior that won't be welcome in commands other than > > > vc-next-action, so I put the arm you added under control of > > > a new boolean argument ALLOW-UNREGISTERED. > > > > Now this points to another issue: > > vc-next-action does this: > > > > (mapc 'vc-register files)) > > > > But vc-register is defined like this: > > > > (defun vc-register (&optional set-revision comment) > > > > i.e. it does not have a file parameter, it works on the current > > buffer. > > > > The easy fix would probably be to change the mapc call to do a > > with-current-buffer. But it might be better to change vc-register to > > take a fileset parameter... > > > Here's a patch that changes vc-register to take a file parameter. In the > end should take a fileset, but it seems better to first make sure that > the simpler case works. I checked this in. Making vc-register have a fileset parameter would probably have to wait until there's a way to test that. Currently vc-dired does not show non-registered files, so one can't select them to create a fileset.