From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: [patch] combined build Date: Thu, 15 Nov 2007 08:28:33 -0800 Message-ID: References: <473C347B.6080907@yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1195144174 11824 80.91.229.12 (15 Nov 2007 16:29:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2007 16:29:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 15 17:29:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ishax-0006Jh-Sp for ged-emacs-devel@m.gmane.org; Thu, 15 Nov 2007 17:29:36 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ishal-00079w-8I for ged-emacs-devel@m.gmane.org; Thu, 15 Nov 2007 11:29:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IshaJ-0006zI-1I for emacs-devel@gnu.org; Thu, 15 Nov 2007 11:28:55 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IshaI-0006yq-B5 for emacs-devel@gnu.org; Thu, 15 Nov 2007 11:28:54 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IshaI-0006yl-0w for emacs-devel@gnu.org; Thu, 15 Nov 2007 11:28:54 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IshaH-00033e-Gm for emacs-devel@gnu.org; Thu, 15 Nov 2007 11:28:53 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lAFGSX6a011569; Thu, 15 Nov 2007 08:28:34 -0800 (PST) In-Reply-To: <473C347B.6080907@yandex.ru> (Dmitry Antipov's message of "Thu, 15 Nov 2007 14:58:51 +0300") Original-Lines: 45 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83278 Archived-At: Dmitry Antipov writes: > This patch provides a minimal support for compiling (the most of) emacs C code at once using > -combine option supported by never versions of GCC. Since an almost everything is compiled > each time when the compiler is invoked, this mode is not suitable for developers. But it might > be useful for package builders and other peoples who just wants to do './configure && make && > make install' sequence. This feature also gives GCC a chance to optimize something during > inter-module analysis. > > Notes: > > 1. Compiling with -combine implies quite strict function declarations vs. definitions checking, > so C code is touched in some places. In particular, current 'fatal' implementation bombs > out combining compilation, and I've redone it with va_args. This might be non-portable or > may break some ancient compiler. I went through exactly this exercise 2 years ago, trying to fix all the combine problems in the tree at that time. I had to undo a similar "fatal" change for these concerns. Now is a good time to reconsider, IMHO we should not support building without varargs. Please note that to get the full benefit of interprocedural optimization you'd also need -fwhole-program, and that implies that the files in lwlib should be added to the temacs compile line. > 2. For me, it doesn't work when using GTK toolkit. When using both GTK and -combine, I've got > the following nasty error messages: > > In file included from /usr/include/gtk-2.0/gtk/gtk.h:74, > from xterm.h:46, > from fns.c:53: > /usr/include/gtk-2.0/gtk/gtkcurve.h:104: error: conflicting types for 'gtk_curve_get_vector' > /usr/include/gtk-2.0/gtk/gtkcurve.h:104: error: previous declaration of 'gtk_curve_get_vector' was here > /usr/include/gtk-2.0/gtk/gtkcurve.h:106: error: conflicting types for 'gtk_curve_set_vector' > /usr/include/gtk-2.0/gtk/gtkcurve.h:106: error: previous declaration of 'gtk_curve_set_vector' was here > > I suspect this is a bug in GCC. So I've installed an additional check in configure.in > to avoid using both GTK and -combine simultaneously. What version of Gtk is this? If you are certain this is a gcc bug, please report it.