doc-view warnings

doc-view warnings

[Dan Nicolaescu]

These might be bugs:

In doc-view-search-backward:
doc-view.el:790:20:Warning: reference to free variable `arg'

In doc-view-search:
doc-view.el:798:17:Warning: reference to free variable `arg'

Re: doc-view warnings

[Tassilo Horn]

Dan Nicolaescu <dann@ics.uci.edu> writes:

Hi Dan!

> These might be bugs:
>
> In doc-view-search-backward:
> doc-view.el:790:20:Warning: reference to free variable `arg'
>
> In doc-view-search:
> doc-view.el:798:17:Warning: reference to free variable `arg'

Oh, yes, they are.  Here's the fix:

--8<---------------cut here---------------start------------->8---
2007-11-16  Tassilo Horn  <tassilo@member.fsf.org>

	* doc-view.el (doc-view-search-backward, doc-view-search): Fix
	assignment to free variable bug.
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
Index: lisp/doc-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/doc-view.el,v
retrieving revision 1.22
diff -u -r1.22 doc-view.el
--- lisp/doc-view.el	16 Nov 2007 16:50:35 -0000	1.22
+++ lisp/doc-view.el	16 Nov 2007 17:04:02 -0000
@@ -787,7 +787,7 @@
   "Call `doc-view-search' for backward search.
 If prefix NEW-QUERY is given, ask for a new regexp."
   (interactive "P")
-  (doc-view-search arg t))
+  (doc-view-search new-query t))
 
 (defun doc-view-search (new-query &optional backward)
   "Jump to the next match or initiate a new search if NEW-QUERY is given.
@@ -795,7 +795,7 @@
 till now do that first.
 If BACKWARD is non-nil, jump to the previous match."
   (interactive "P")
-  (if (and (not arg)
+  (if (and (not new-query)
 	   doc-view-current-search-matches)
       (if backward
 	  (doc-view-search-previous-match 1)
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

Re: doc-view warnings

[Dan Nicolaescu]

Tassilo Horn <tassilo@member.fsf.org> writes:

  > Dan Nicolaescu <dann@ics.uci.edu> writes:
  > 
  > Hi Dan!
  > 
  > > These might be bugs:
  > >
  > > In doc-view-search-backward:
  > > doc-view.el:790:20:Warning: reference to free variable `arg'
  > >
  > > In doc-view-search:
  > > doc-view.el:798:17:Warning: reference to free variable `arg'
  > 
  > Oh, yes, they are.  Here's the fix:

Thanks, checked in.