From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: Re: (if (and (featurep 'xemacs) blah) not optimized anymore Date: Tue, 13 Nov 2007 08:12:05 -0800 Message-ID: References: <200710201609.l9KG9PFJ006092@oogie-boogie.ics.uci.edu> <200710220545.l9M5jmvI010460@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194970443 30795 80.91.229.12 (13 Nov 2007 16:14:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Nov 2007 16:14:03 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 13 17:14:05 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IryOi-0007sQ-Q2 for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2007 17:13:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IryOV-0003S3-PQ for ged-emacs-devel@m.gmane.org; Tue, 13 Nov 2007 11:13:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IryOS-0003Rh-5d for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:13:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IryOQ-0003RL-II for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:13:39 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IryOQ-0003RI-F9 for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:13:38 -0500 Original-Received: from oogie-boogie.ics.uci.edu ([128.195.1.41]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IryOP-0005bC-Az for emacs-devel@gnu.org; Tue, 13 Nov 2007 11:13:37 -0500 Original-Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by oogie-boogie.ics.uci.edu (8.13.6/8.13.6) with ESMTP id lADGC5rY004610; Tue, 13 Nov 2007 08:12:05 -0800 (PST) Original-Lines: 30 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@ics.uci.edu X-detected-kernel: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:83131 Archived-At: Stefan Monnier writes: > > I still see one issue: > > > After applying this patch: > > > --- viper-cmd.el 19 Aug 2007 13:47:07 -0000 1.63 > > +++ viper-cmd.el 22 Oct 2007 05:37:24 -0000 > > @@ -861,7 +861,7 @@ > > (1- (length quail-current-str))))) > > )) > > ((and viper-special-input-method > > - viper-xemacs-p > > + nil > > (fboundp 'quail-start-translation)) > > ;; same as above but for XEmacs, which doesn't have > > ;; quail-input-method > > > the byte compiler will still warn about about quail-start-translation > > not being defined. I won't warn if the expression is > > (and nil viper-special-input-method ...) > > The patch below seems to fix it, but it does a bit more and I'm not sure > if it behaves well in practice (e.g. performancewise), so please try it > out on a large scale. If you find it to work well, feel free to > install it. Thanks! The bootstrap time from a clean state went from 400s to 402s, so I checked this in.