From: Dan Nicolaescu <dann@ics.uci.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: (if (and (featurep 'xemacs) blah) not optimized anymore
Date: Tue, 13 Nov 2007 08:12:05 -0800 [thread overview]
Message-ID: <ur93avaw2ei.fsf@mothra.ics.uci.edu> (raw)
In-Reply-To: jwv6406mchh.fsf-monnier+emacs@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> > I still see one issue:
>
> > After applying this patch:
>
> > --- viper-cmd.el 19 Aug 2007 13:47:07 -0000 1.63
> > +++ viper-cmd.el 22 Oct 2007 05:37:24 -0000
> > @@ -861,7 +861,7 @@
> > (1- (length quail-current-str)))))
> > ))
> > ((and viper-special-input-method
> > - viper-xemacs-p
> > + nil
> > (fboundp 'quail-start-translation))
> > ;; same as above but for XEmacs, which doesn't have
> > ;; quail-input-method
>
> > the byte compiler will still warn about about quail-start-translation
> > not being defined. I won't warn if the expression is
> > (and nil viper-special-input-method ...)
>
> The patch below seems to fix it, but it does a bit more and I'm not sure
> if it behaves well in practice (e.g. performancewise), so please try it
> out on a large scale. If you find it to work well, feel free to
> install it.
Thanks!
The bootstrap time from a clean state went from 400s to 402s, so I
checked this in.
prev parent reply other threads:[~2007-11-13 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 16:09 (if (and (featurep 'xemacs) blah) not optimized anymore Dan Nicolaescu
2007-10-21 16:26 ` Richard Stallman
2007-10-21 20:10 ` Stefan Monnier
2007-10-22 3:00 ` Dan Nicolaescu
2007-10-22 4:58 ` Stefan Monnier
2007-10-22 5:45 ` Dan Nicolaescu
2007-11-13 14:46 ` Stefan Monnier
2007-11-13 16:12 ` Dan Nicolaescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ur93avaw2ei.fsf@mothra.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).