From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Preventing warnings in FIXNUM_OVERFLOW_P Date: Sat, 20 Jan 2007 15:45:25 +0200 Message-ID: References: <85lkk0npzj.fsf@lola.goethe.zz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1169300748 7070 80.91.229.12 (20 Jan 2007 13:45:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 20 Jan 2007 13:45:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 20 14:45:44 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H8GXK-0000CL-7s for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2007 14:45:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H8GXK-0002wU-MY for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2007 08:45:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H8GX3-0002sB-RI for emacs-devel@gnu.org; Sat, 20 Jan 2007 08:45:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1H8GX2-0002q0-2C for emacs-devel@gnu.org; Sat, 20 Jan 2007 08:45:21 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H8GX1-0002px-Su for emacs-devel@gnu.org; Sat, 20 Jan 2007 08:45:19 -0500 Original-Received: from [213.8.233.24] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1H8GX0-0005u4-Mq; Sat, 20 Jan 2007 08:45:18 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-199-87.inter.net.il [80.230.199.87]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id GXE65994 (AUTH halo1); Sat, 20 Jan 2007 15:45:19 +0200 (IST) Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Fri, 19 Jan 2007 21:10:44 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65324 Archived-At: > From: Richard Stallman > CC: eliz@gnu.org, emacs-devel@gnu.org > Date: Fri, 19 Jan 2007 21:10:44 -0500 > > > I say let's leave my workaround alone until the GCC developers move > > this warning into -Wextra. When that version of GCC becomes > > widespread, we can remove the workaround. > > Agreed, > > That is a bad solution. Turning off this warning globally risks > missing other places where there is a real problem. The right > solution is a way to turn off the warning _only in this construct_. But this argument is applicable to _every_ warning GCC is programmed to emit! including those that are already in -Wall and -Wextra, about which you yourself argued in the past that they should not be issued by default. Every warning can sometimes flag code that is a real problem, that's the reason we have those warnings in the first place. If we are to accept your argument, why not use -Wall globally, and then go over the warnings and turn each one only in those places where we know the code is correct?