From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Icon displayed wrong Date: Sat, 19 May 2007 11:16:50 +0300 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179562632 10229 80.91.229.12 (19 May 2007 08:17:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 19 May 2007 08:17:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: James Cloos Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 19 10:17:10 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HpK7g-0001sd-Q0 for ged-emacs-devel@m.gmane.org; Sat, 19 May 2007 10:17:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HpK7f-0002Wg-C8 for ged-emacs-devel@m.gmane.org; Sat, 19 May 2007 04:17:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HpK7a-0002WR-Om for emacs-devel@gnu.org; Sat, 19 May 2007 04:17:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HpK7Z-0002Vi-CG for emacs-devel@gnu.org; Sat, 19 May 2007 04:17:02 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HpK7Z-0002Vf-3J for emacs-devel@gnu.org; Sat, 19 May 2007 04:17:01 -0400 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HpK7Y-0001Ij-4N for emacs-devel@gnu.org; Sat, 19 May 2007 04:17:00 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-84-229-254-231.inter.net.il [84.229.254.231]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id CPS55222 (AUTH halo1); Sat, 19 May 2007 11:16:48 +0300 (IDT) In-reply-to: (message from James Cloos on Sat, 19 May 2007 03:49:36 -0400) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71374 Archived-At: > From: James Cloos > Cc: emacs-devel@gnu.org > Date: Sat, 19 May 2007 03:49:36 -0400 > > Eli> Can you explain why? > > The images directory has both B/W and Colour versions of each icon. The > Colour versions are all xpm (X pixmap) files, and the B/W are all pbm > (Portable Bitmap) files. All except cancel.pbm which has (had, on > trunk, now that Glenn updated it) the bitmap extension but is (was) a > grayscale file using only colours 0 and 255. > > Converting it simply makes it match all of the other icons, and it > obviously was intended to be a P4 pbm file when it was first commited; > whoever saved it from Gimp just "typo"ed the SaveAs on that one file. In other words, you are saying it should be converted for consistency. Note that there are a couple of other *.pbm files in etc/images that on the branch are not PBM files. For example, copy.pbm is a PPM file. Are we sure they all are due to typo-style mistakes? > If there is any chance of .990 getting simply renamed as 22.1 There's exactly 0% chance that this will happen, because some source files need to be modified to change the version number, and the ChangeLog files need to be marked with the release entry. > then I > agree with Glenn's decision not to also make then change on the release > branch. But it should then get done there for 22.2. I actually agree with Glenn's decision not to touch the release branch; see my other mail in this thread where I report that the converted image file behaves differently from the original PGM one. It is these unintended consequences that we should consider when we discuss changes for non-critical problems.