From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Failure in building Emacs 23.0.50 on Cygwin
Date: Sat, 01 Sep 2007 11:18:08 +0300
Message-ID: <ur6livlxb.fsf@gnu.org>
References: <Pine.CYG.4.58.0708300104560.2536@homepc>
	<20070901091956.1876@blackhawk>
	<200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu>
	<20070901125313.1488@blackhawk>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: sea.gmane.org 1188634709 13029 80.91.229.12 (1 Sep 2007 08:18:29 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 1 Sep 2007 08:18:29 +0000 (UTC)
Cc: dann@ics.uci.edu, emacs-devel@gnu.org
To: "d.henman" <dhenman@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 01 10:18:25 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1IROBS-0003jQ-6Y
	for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 10:18:22 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1IROBR-0008B0-Bl
	for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 04:18:21 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IROBH-00081l-AN
	for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:18:11 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IROBF-00080a-Kj
	for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:18:10 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IROBF-00080P-Eq
	for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:18:09 -0400
Original-Received: from heller.inter.net.il ([213.8.233.23])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <eliz@gnu.org>) id 1IROBE-0005Io-W2
	for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:18:09 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-59-157.inter.net.il
	[80.230.59.157]) by heller.inter.net.il (MOS 3.7.3a-GA)
	with ESMTP id DMV75567 (AUTH halo1);
	Sat, 1 Sep 2007 11:18:06 +0300 (IDT)
In-reply-to: <20070901125313.1488@blackhawk> (dhenman@gmail.com)
X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:77538
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/77538>

> From: "d.henman" <dhenman@gmail.com>
> Date: Sat, 01 Sep 2007 12:53:13 +0900
> Cc: emacs-devel@gnu.org
> 
> --- term.c	2007-08-30 06:46:50.000000000 +0900
> +++ term.c.fixed	2007-09-01 10:39:51.906250000 +0900
> @@ -3142,8 +3142,10 @@
>          emacs_close (fd);
>        sigunblock (sigmask (SIGTTOU));
>  #else
> +#ifndef CYGWIN
>        /* Unknown system. */
>        croak ();
> +#endif  /* ! CYGWIN */
>  #endif  /* ! TIOCNOTTY */
>  #endif  /* ! USG */
>      }
> 
> --=-=-=
> 
> 
> Please review this and let me know if I can check it into cvs.

Please don't, as I think it;s the wrong way of fixing the problem.

I think the idea of defining `croak' for all platforms in sysdep.c is
a better one.