From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Problem with library images on Windows (again) Date: Sat, 21 May 2005 22:13:57 +0100 Message-ID: References: <428DB8F3.3070108@gnu.org> <01c55d4a$Blat.v2.4$8e2e76e0@zahav.net.il> <428E065E.6040307@gnu.org> <01c55d54$Blat.v2.4$04c543c0@zahav.net.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1116710369 14138 80.91.229.2 (21 May 2005 21:19:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 May 2005 21:19:29 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 21 23:19:25 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DZbMt-0001Uf-Ex for ged-emacs-devel@m.gmane.org; Sat, 21 May 2005 23:18:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZbQ0-0004Iv-PF for ged-emacs-devel@m.gmane.org; Sat, 21 May 2005 17:22:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DZbPX-0004Fu-2r for emacs-devel@gnu.org; Sat, 21 May 2005 17:21:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DZbPQ-0004Ei-TD for emacs-devel@gnu.org; Sat, 21 May 2005 17:21:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DZbPO-00048t-Rz for emacs-devel@gnu.org; Sat, 21 May 2005 17:21:22 -0400 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1DZbRN-0003kY-5N for emacs-devel@gnu.org; Sat, 21 May 2005 17:23:25 -0400 Original-Received: from wanchan.jasonrumney.net (i-195-137-77-250.freedom2surf.net [195.137.77.250]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id j4LLEJch008168; Sat, 21 May 2005 22:14:19 +0100 Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 51029DDE2F; Sat, 21 May 2005 22:14:19 +0100 (BST) Original-To: Juanma Barranquero In-Reply-To: (Juanma Barranquero's message of "Sat, 21 May 2005 12:33:51 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37441 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37441 Juanma Barranquero writes: >> If the other image libraries we use also use C calling conventions, >> then that is the correct fix, I think. > > However, and in the interest of peace of mind, I'll trace the > functions and see that they're really doing what I think :) Studying the headers, png and jpeg explicitly use _cdecl (or __cdecl depending on compiler), while xpm and gif specify nothing (so will default to _cdecl). So the fix you suggested is correct, I think.