From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Options menu is broken on CVS Date: Wed, 07 Sep 2005 07:16:31 +0300 Message-ID: References: <200509062007.04648.ismail@uludag.org.tr> <17181.65500.337376.386116@farnswood.snap.net.nz> <200509062349.18090.ismail@uludag.org.tr> <17182.8135.530028.132576@farnswood.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1126066813 444 80.91.229.2 (7 Sep 2005 04:20:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 7 Sep 2005 04:20:13 +0000 (UTC) Cc: ismail@uludag.org.tr, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 07 06:20:05 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ECrPe-0003hH-Rd for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2005 06:19:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECrUB-0008Cx-Am for ged-emacs-devel@m.gmane.org; Wed, 07 Sep 2005 00:24:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ECrSg-0007C1-2y for emacs-devel@gnu.org; Wed, 07 Sep 2005 00:23:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ECrSc-00079m-Hp for emacs-devel@gnu.org; Wed, 07 Sep 2005 00:22:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ECrSc-00079K-5d for emacs-devel@gnu.org; Wed, 07 Sep 2005 00:22:58 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ECrQY-0006Yl-8o for emacs-devel@gnu.org; Wed, 07 Sep 2005 00:20:50 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-251-46.inter.net.il [83.130.251.46]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id CHU55006 (AUTH halo1); Wed, 7 Sep 2005 07:16:30 +0300 (IDT) Original-To: Nick Roberts In-reply-to: <17182.8135.530028.132576@farnswood.snap.net.nz> (message from Nick Roberts on Wed, 7 Sep 2005 11:01:27 +1200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42687 Archived-At: > From: Nick Roberts > Date: Wed, 7 Sep 2005 11:01:27 +1200 > Cc: emacs-devel@gnu.org > > It seems to be due to this change: > > 2004-03-13 Eli Zaretskii > > * emacs.c (main): Call syms_of_xmenu only if HAVE_MENUS is defined. > > I guess it hasn't been noticed before because, although people may use tmm, > most use a version of Emacs thats compiled with X (or at least HAVE_MENUS). > > I haven't reverted this change because it must be there for a reason. Eli? It _was_ for a reason. The 2 related changes I committed at that time were these: 2004-03-13 Eli Zaretskii * Makefile.in (XMENU_OBJ): Include xmenu.o if HAVE_MENUS is defined. * emacs.c (main): Call syms_of_xmenu only if HAVE_MENUS is defined. I don't remember the details (you will probably find them in emacs-devel or emacs-pretest-bug archives for that period of time), but there was some build failure, I think on MacOS, which these changes were part of fixing. Please don't take out this change without understanding what it was fixing in the first place.