From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@suse.de>
Cc: ulm@gentoo.org, emacs-devel@gnu.org
Subject: Re: endianness test in md5.c
Date: Sat, 18 Oct 2008 11:15:50 +0200 [thread overview]
Message-ID: <uod1il0vt.fsf@gnu.org> (raw)
In-Reply-To: <jeprlys24u.fsf@sykes.suse.de>
> From: Andreas Schwab <schwab@suse.de>
> Date: Sat, 18 Oct 2008 11:06:57 +0200
> Cc: emacs-devel@gnu.org
>
> Ulrich Mueller <ulm@gentoo.org> writes:
>
> > src/md5.c contains the following code:
> >
> > # include <endian.h>
> > # if __BYTE_ORDER == __BIG_ENDIAN
> > # define WORDS_BIG_ENDIAN 1
> > # endif
> >
> > I wonder, shouldn't it just use the macro defined in m/*.h instead
> > (at least for the case that HAVE_CONFIG_H is defined)?
>
> This is only used when compiled as part of glibc.
Exactly. And md5.c is imported from glibc, so we don't want to make
local changes to it that are not necessary for Emacs, to make
importing future versions easier.
prev parent reply other threads:[~2008-10-18 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 8:27 endianness test in md5.c Ulrich Mueller
2008-10-18 9:06 ` Andreas Schwab
2008-10-18 9:15 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uod1il0vt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).