From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacsclient's option decoding code Date: Mon, 03 Nov 2008 22:06:27 +0200 Message-ID: References: <87wsflyf80.fsf@cyd.mit.edu> <87k5blzphq.fsf@cyd.mit.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1225742852 19627 80.91.229.12 (3 Nov 2008 20:07:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Nov 2008 20:07:32 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 03 21:08:33 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kx5iF-00035T-5q for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2008 21:07:47 +0100 Original-Received: from localhost ([127.0.0.1]:49418 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kx5h7-0007WM-I6 for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2008 15:06:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kx5h1-0007VX-Ey for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:06:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kx5h0-0007VD-FC for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:06:31 -0500 Original-Received: from [199.232.76.173] (port=54108 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kx5h0-0007V8-Bt for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:06:30 -0500 Original-Received: from mtaout5.012.net.il ([84.95.2.13]:16449) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kx5gz-0004sv-Kr for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:06:29 -0500 Original-Received: from HOME-C4E4A596F7 ([77.127.192.143]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K9R00KHZX9GM821@i_mtaout5.012.net.il> for emacs-devel@gnu.org; Mon, 03 Nov 2008 22:08:10 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105309 Archived-At: > Date: Mon, 3 Nov 2008 13:12:33 +0100 > From: "Juanma Barranquero" > Cc: cyd@stupidchicken.com, emacs-devel@gnu.org > > The following proof-of-concept patch seems to work (at the cost of > adding windows-specific conditions). Thanks, but I'd like to look for a cleaner patch, one that doesn't add new ifdef's. > --- lisp/server.el 30 Oct 2008 15:50:01 -0000 1.171 > +++ lisp/server.el 3 Nov 2008 12:06:49 -0000 > @@ -631,10 +631,12 @@ > ;; This is a leftover, see above. > (environment . ,(process-get proc 'env)))) > - (frame (make-frame-on-display > + (frame (if (eq system-type 'windows-nt) > + (make-frame params) > + (make-frame-on-display > (or display > (frame-parameter nil 'display) > (getenv "DISPLAY") > (error "Please specify display")) > - params))) > + params)))) > (server-log (format "%s created" frame) proc) > (select-frame frame) > Here' I think it's unclean that the w32 port has make-frame-on-display fboundp, but it's dysfunctional when called. If make-frame-on-display can be made to work on Windows, provided that `display' is nil (or maybe it should ignore `display' even if non-nil?), that would be a cleaner and more general change.