[Bug] Unusual wide Chinese fonts on w32 (again)

[Bug] Unusual wide Chinese fonts on w32 (again)

[Sun Yijiang]

[-- Attachment #1.1: Type: text/plain, Size: 692 bytes --]

I made a bug report and patch for this. It's actually an undo of
w32fns.ccommit by Jason Rumney on 2005-01-03 (check src/ChangeLog for
details). The
2nd item of that ChangeLog entry is the cause of this problem.

I wonder why this has not been fixed yet, maybe he cannot make tests on his
computer? It's easy to verify: use `create-fontset-from-fontset-spec' to
assign a font for chinese-gb2312 and you can see all Chinese chars is 4
times wide of ascii chars.

That's really a serious bug! It's only on w32 and only appears with
`create-fontset-from-fontset-spec'. A simple undo can solve this problem,
but maybe it's not the best way. Anyway, I hope somebody can get it fixed.

[-- Attachment #1.2: Type: text/html, Size: 750 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [Bug] Unusual wide Chinese fonts on w32 (again)

[Jason Rumney]

Sun Yijiang <sunyijiang@gmail.com> writes:

> I made a bug report and patch for this. It's actually an undo of
> w32fns.c commit by Jason Rumney on 2005-01-03
>
> I wonder why this has not been fixed yet

Because the fix is not as simple as reverting to a previous bug.

Re: [Bug] Unusual wide Chinese fonts on w32 (again)

[Jason Rumney]

Sun Yijiang <sunyijiang@gmail.com> writes:

> I wonder why this has not been fixed yet, maybe he cannot make tests on his
> computer? It's easy to verify: use `create-fontset-from-fontset-spec' to
> assign a font for chinese-gb2312 and you can see all Chinese chars is 4
> times wide of ascii chars.

I have made a change that fixes this bug. There is still a problem if
create-fontset-from-ascii-font is used with a font with double-width
characters and font-lock is enabled. I think the problem is
limited to Windows because on X always uses separate fonts for
different encodings, but it appears that FONT_WIDTH,
FONT_AVERAGE_WIDTH and the actual character metrics are still not used
in a consistent way throughout the code.

Re: [Bug] Unusual wide Chinese fonts on w32 (again)

[Sun Yijiang]

[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]

I made a cvs update and a w32 build, the bug seems gone. I'm using
create-fontset-from-ascii-font and chinese characters with font-lock on,
everything seems OK.

2005/10/26, Jason Rumney <jasonr@gnu.org>:
>
> Sun Yijiang <sunyijiang@gmail.com> writes:
>
> > I wonder why this has not been fixed yet, maybe he cannot make tests on
> his
> > computer? It's easy to verify: use `create-fontset-from-fontset-spec' to
> > assign a font for chinese-gb2312 and you can see all Chinese chars is 4
> > times wide of ascii chars.
>
> I have made a change that fixes this bug. There is still a problem if
> create-fontset-from-ascii-font is used with a font with double-width
> characters and font-lock is enabled. I think the problem is
> limited to Windows because on X always uses separate fonts for
> different encodings, but it appears that FONT_WIDTH,
> FONT_AVERAGE_WIDTH and the actual character metrics are still not used
> in a consistent way throughout the code.
>

[-- Attachment #1.2: Type: text/html, Size: 1290 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: [Bug] Unusual wide Chinese fonts on w32 (again)

[Jason Rumney]

Sun Yijiang <sunyijiang@gmail.com> writes:

> I made a cvs update and a w32 build, the bug seems gone. I'm using
> create-fontset-from-ascii-font and chinese characters with font-lock on,
> everything seems OK.

Thank you for confirming this.