From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: GNU Emacs CVS HEAD: Date: Sat, 21 Jan 2006 22:12:37 +0200 Message-ID: References: <6d66855c0601182207t76b8bd41qb3cc4eba0ad5c8ed@mail.gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1137874455 11445 80.91.229.2 (21 Jan 2006 20:14:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 Jan 2006 20:14:15 +0000 (UTC) Cc: offby1@blarg.net, emacs-devel@gnu.org, handa@m17n.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 21 21:14:14 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F0P7j-0003i6-Js for ged-emacs-devel@m.gmane.org; Sat, 21 Jan 2006 21:14:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F0PAH-0003WR-Gd for ged-emacs-devel@m.gmane.org; Sat, 21 Jan 2006 15:16:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F0P9M-0002u1-5m for emacs-devel@gnu.org; Sat, 21 Jan 2006 15:15:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F0P9L-0002sE-1b for emacs-devel@gnu.org; Sat, 21 Jan 2006 15:15:51 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F0P9K-0002rX-8G for emacs-devel@gnu.org; Sat, 21 Jan 2006 15:15:50 -0500 Original-Received: from [192.114.186.17] (helo=gandalf.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1F0PDk-0000Sr-N2; Sat, 21 Jan 2006 15:20:25 -0500 Original-Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) by gandalf.inter.net.il (MOS 3.7.1-GA) with ESMTP id HQL06775; Sat, 21 Jan 2006 22:12:33 +0200 (IST) Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-205-150.inter.net.il [83.130.205.150]) by nitzan.inter.net.il (MOS 3.7.3-GA) with ESMTP id CNH04675 (AUTH halo1); Sat, 21 Jan 2006 22:12:30 +0200 (IST) Original-To: rms@gnu.org In-reply-to: (rms@gnu.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49364 Archived-At: > From: "Richard M. Stallman" > CC: handa@m17n.org, offby1@blarg.net, emacs-devel@gnu.org > Date: Sat, 21 Jan 2006 14:58:13 -0500 > > I have some idea. What I see in the debugger is that, when loadup > comes to load cyrillic.el, the file just before indian.el, it > repeatedly calls `openp' to load code-pages.el, but never closes the > resulting handle. The reason it doesn't close it is that, after > `openp' returns, Fload checks if we are in recursive load cycle, and > finds that we are! (After the loop which looks at Vloads_in_progress, > `count's value is 4.) It then calls Fsignal to signal this error, but > since we are in a protected form, Fsignal just unwinds there, and the > load continues (or so it seems). > > It seems there are two bugs here. One is that it recursively > loads one file. The other is that it doesn't close the handles. > Perhaps that's due to a missing unwind_protect. Meanwhile, I fixed the second problem. There's no need to unwind_protect, all we need is close the handle before we call Fsignal.