From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.os.cygwin,gmane.emacs.devel
Subject: Re: A warning building Emacs-cvs with recent Cygwin DLL
Date: Fri, 25 Jan 2008 12:16:30 +0200
Message-ID: <umyqumcqp.fsf@gnu.org>
References: <4799A7E4.9020203@alice.it>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: ger.gmane.org 1201256228 25574 80.91.229.12 (25 Jan 2008 10:17:08 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 25 Jan 2008 10:17:08 +0000 (UTC)
Cc: emacs-devel@gnu.org, cygwin@cygwin.com
To: Angelo Graziosi <angelo.graziosi@alice.it>
Original-X-From: cygwin-return-138918-goc-cygwin=m.gmane.org@cygwin.com Fri Jan 25 11:17:28 2008
Return-path: <cygwin-return-138918-goc-cygwin=m.gmane.org@cygwin.com>
Envelope-to: goc-cygwin@gmane.org
Original-Received: from sourceware.org ([209.132.176.174])
	by lo.gmane.org with smtp (Exim 4.50)
	id 1JILcf-0007xj-Gy
	for goc-cygwin@gmane.org; Fri, 25 Jan 2008 11:17:21 +0100
Original-Received: (qmail 16701 invoked by alias); 25 Jan 2008 10:16:50 -0000
Original-Received: (qmail 16692 invoked by uid 22791); 25 Jan 2008 10:16:50 -0000
X-Spam-Check-By: sourceware.org
Original-Received: from romy.inter.net.il (HELO romy.inter.net.il) (213.8.233.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jan 2008 10:16:30 +0000
Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-250-87.inter.net.il [80.230.250.87]) 	by romy.inter.net.il (MOS 3.7.3-GA) 	with ESMTP id KAG68884 (AUTH halo1); 	Fri, 25 Jan 2008 12:16:07 +0200 (IST)
In-reply-to: <4799A7E4.9020203@alice.it> (message from Angelo Graziosi on Fri, 	25 Jan 2008 10:12:04 +0100)
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-goc-cygwin=m.gmane.org@cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Original-Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Xref: news.gmane.org gmane.os.cygwin:95080 gmane.emacs.devel:87488
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/87488>

> Date: Fri, 25 Jan 2008 10:12:04 +0100
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Cc: cygwin@cygwin.com
> 
> With Cygwin DLL 1.5.25 (and the changes to 'tz...', I suppose), building 
> Emacs from CVS gives this warning:
> 
> ...
> gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src 
> -I/usr/X11R6/include    -g -O2 -Wno-pointer-sign  /tmp/emacs/src/strftime.c
> 
> /tmp/emacs/src/strftime.c:58: warning: '_tzname' redeclared without 
> dllimport attribute: previous dllimport ignored
> ...
> 
> It seems that the following simple patch avoid it:
> =================================================
> --- strftime.c.orig	2007-01-14 04:24:37.000000000 +0100
> +++ strftime.c	2008-01-24 12:04:40.031250000 +0100
> @@ -55,9 +55,13 @@
>   #endif
>   #if HAVE_TZNAME
>   #ifndef USE_CRT_DLL
> +#ifdef __CYGWIN__
> +extern __IMPORT char *tzname[];
> +#else
>   extern char *tzname[];
>   #endif
>   #endif
> +#endif

Thanks.  But it's better to put this kind of platform-dependent stuff
in src/s/cygwin.h, not in general source files.  Would that work for
you?