Re: A warning building Emacs-cvs with recent Cygwin DLL

[Eli Zaretskii <eliz@gnu.org>]

> Date: Fri, 25 Jan 2008 10:12:04 +0100
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Cc: cygwin@cygwin.com
> 
> With Cygwin DLL 1.5.25 (and the changes to 'tz...', I suppose), building 
> Emacs from CVS gives this warning:
> 
> ...
> gcc -c  -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/tmp/emacs/src 
> -I/usr/X11R6/include    -g -O2 -Wno-pointer-sign  /tmp/emacs/src/strftime.c
> 
> /tmp/emacs/src/strftime.c:58: warning: '_tzname' redeclared without 
> dllimport attribute: previous dllimport ignored
> ...
> 
> It seems that the following simple patch avoid it:
> =================================================
> --- strftime.c.orig	2007-01-14 04:24:37.000000000 +0100
> +++ strftime.c	2008-01-24 12:04:40.031250000 +0100
> @@ -55,9 +55,13 @@
>   #endif
>   #if HAVE_TZNAME
>   #ifndef USE_CRT_DLL
> +#ifdef __CYGWIN__
> +extern __IMPORT char *tzname[];
> +#else
>   extern char *tzname[];
>   #endif
>   #endif
> +#endif

Thanks.  But it's better to put this kind of platform-dependent stuff
in src/s/cygwin.h, not in general source files.  Would that work for
you?