From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: error in server-running-p on M$ Date: Sat, 22 Nov 2008 15:53:43 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1227362040 16232 80.91.229.12 (22 Nov 2008 13:54:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Nov 2008 13:54:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 22 14:55:03 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L3sww-0001Rf-M7 for ged-emacs-devel@m.gmane.org; Sat, 22 Nov 2008 14:55:02 +0100 Original-Received: from localhost ([127.0.0.1]:37505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3svn-0006iY-P3 for ged-emacs-devel@m.gmane.org; Sat, 22 Nov 2008 08:53:51 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3svh-0006hZ-Hi for emacs-devel@gnu.org; Sat, 22 Nov 2008 08:53:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3svg-0006gj-4v for emacs-devel@gnu.org; Sat, 22 Nov 2008 08:53:44 -0500 Original-Received: from [199.232.76.173] (port=34540 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3svg-0006gZ-0r for emacs-devel@gnu.org; Sat, 22 Nov 2008 08:53:44 -0500 Original-Received: from mtaout5.012.net.il ([84.95.2.13]:15453) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L3svf-0000iN-GO for emacs-devel@gnu.org; Sat, 22 Nov 2008 08:53:43 -0500 Original-Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KAQ00J00MLLZ800@i_mtaout5.012.net.il> for emacs-devel@gnu.org; Sat, 22 Nov 2008 15:55:42 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.14.29]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KAQ000DHMOTDUE1@i_mtaout5.012.net.il>; Sat, 22 Nov 2008 15:55:42 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105951 Archived-At: > Date: Sat, 22 Nov 2008 14:37:02 +0100 > From: "Juanma Barranquero" > Cc: emacs-devel@gnu.org > > He said: "Currently it's not used (except in some people's .emacs). > The intended use is in start-server to try and prevent hijacking the > socket of a pre-existing server." But that is just part of the > answer, I think. I'm okay with going with this partial answer. > Index: lisp/server.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/server.el,v > retrieving revision 1.173 > diff -u -2 -r1.173 server.el > --- lisp/server.el 5 Nov 2008 21:16:17 -0000 1.173 > +++ lisp/server.el 7 Nov 2008 15:37:36 -0000 > @@ -537,5 +537,15 @@ > (unless name (setq name server-name)) > (condition-case nil > - (progn > + (if server-use-tcp > + (with-temp-buffer > + (insert-file-contents-literally > + (expand-file-name server-name server-auth-dir)) > + (and (looking-at "127\.0\.0\.1:[0-9]+ \\([0-9]+\\)") > + (let ((case-fold-search t) > + (proc (assq 'comm > + (system-process-attributes > + (string-to-number (match-string 1)))))) > + (and proc > + (string-match-p "emacs" (cdr proc)))))) > (delete-process > (make-network-process > Does anyone see any problems with this change? If not, I suggest to install it.