From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: EOL conversion of files in .tar archives
Date: Wed, 23 May 2007 10:10:52 +0300
Message-ID: <ulkfgj9qb.fsf@gnu.org>
References: <u1whb5m6p.fsf@gnu.org> <E1Hpzoi-0001mB-Vh@etlken.m17n.org>
	<u1wh9kswd.fsf@gnu.org> <E1HqfYE-00032e-46@etlken.m17n.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: sea.gmane.org 1179904266 9064 80.91.229.12 (23 May 2007 07:11:06 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 23 May 2007 07:11:06 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Kenichi Handa <handa@m17n.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 23 09:11:00 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1Hqkzr-0004rv-5F
	for ged-emacs-devel@m.gmane.org; Wed, 23 May 2007 09:10:59 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1Hqkzr-0006le-R3
	for ged-emacs-devel@m.gmane.org; Wed, 23 May 2007 03:10:59 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Hqkzo-0006lR-M4
	for emacs-devel@gnu.org; Wed, 23 May 2007 03:10:56 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Hqkzm-0006l3-Re
	for emacs-devel@gnu.org; Wed, 23 May 2007 03:10:56 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Hqkzm-0006l0-Kv
	for emacs-devel@gnu.org; Wed, 23 May 2007 03:10:54 -0400
Original-Received: from heller.inter.net.il ([213.8.233.23])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <eliz@gnu.org>) id 1Hqkzl-0006YN-1T
	for emacs-devel@gnu.org; Wed, 23 May 2007 03:10:53 -0400
Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-9-138.inter.net.il [80.230.9.138])
	by heller.inter.net.il (MOS 3.7.3a-GA)
	with ESMTP id CQJ53075 (AUTH halo1);
	Wed, 23 May 2007 10:10:46 +0300 (IDT)
In-reply-to: <E1HqfYE-00032e-46@etlken.m17n.org> (message from Kenichi Handa
	on Wed, 23 May 2007 10:22:06 +0900)
X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:71645
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/71645>

> From: Kenichi Handa <handa@m17n.org>
> CC: emacs-devel@gnu.org
> Date: Wed, 23 May 2007 10:22:06 +0900
> 
> > +(defun tar-file-name-handler (op &rest args)
> > +  "Helper function for `tar-extract'."
> > +  (or (eq op 'file-exists-p)
> > +      (let ((file-name-handler-alist nil))
> > +	(apply op args))))
> 
> Is it ok to check only file-exists-p?  How about
> file-readable-p?

It only catches file-exists-p because that's what
find-buffer-file-type-coding-system tries.

> > Sorry, that patch was incomplete, and so did an imperfect job.  Please
> > use the one below.
> 
> Does this new version have the following problem too?

I didn't try loading dos-w32.el again with the last patch because it
produces the correct results with the preloaded dos-w32.el.  In any
case, that seems to be a different problem (if it is indeed a
problem), see my other message in this thread.