From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: C-M-TAB stand-in for M-TAB, on MS Windows? Date: Tue, 27 May 2008 21:49:00 +0300 Message-ID: References: <007901c8bec5$4179df80$0200a8c0@us.oracle.com> <3F8C7B43-05C3-4970-91DA-73152E9286E8@pobox.com> <483AE253.1010208@gmail.com> <000001c8bf4e$ef90aed0$0200a8c0@us.oracle.com> <483AEDA0.1000105@gmail.com> <000201c8bf54$0a312490$0200a8c0@us.oracle.com> <483B27CA.9000102@gmail.com> <000801c8bf88$47c9e3d0$0200a8c0@us.oracle.com> <483B4B4A.8010502@gmail.com> <000901c8bf8f$420017b0$0200a8c0@us.oracle.com> <483BAEDB.6020709@gmail.com> <002a01c8c008$65fd4e70$0200a8c0@us.oracle.com> <003201c8c014$198f9be0$0200a8c0@us.oracle.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1211914153 12248 80.91.229.12 (27 May 2008 18:49:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 May 2008 18:49:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 27 20:49:53 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K14F5-0002cB-SG for ged-emacs-devel@m.gmane.org; Tue, 27 May 2008 20:49:52 +0200 Original-Received: from localhost ([127.0.0.1]:46060 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K14EK-0007WF-F4 for ged-emacs-devel@m.gmane.org; Tue, 27 May 2008 14:49:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K14EF-0007WA-71 for emacs-devel@gnu.org; Tue, 27 May 2008 14:48:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K14EE-0007Vw-9I for emacs-devel@gnu.org; Tue, 27 May 2008 14:48:58 -0400 Original-Received: from [199.232.76.173] (port=56022 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K14EE-0007Vt-4N for emacs-devel@gnu.org; Tue, 27 May 2008 14:48:58 -0400 Original-Received: from mtaout4.012.net.il ([84.95.2.10]:60896) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K14ED-0004cI-Lb for emacs-devel@gnu.org; Tue, 27 May 2008 14:48:58 -0400 Original-Received: from HOME-C4E4A596F7 ([83.130.219.40]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K1J001VJJM64991@i_mtaout4.012.net.il> for emacs-devel@gnu.org; Tue, 27 May 2008 22:03:42 +0300 (IDT) In-reply-to: <003201c8c014$198f9be0$0200a8c0@us.oracle.com> X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97823 Archived-At: > From: "Drew Adams" > Date: Tue, 27 May 2008 09:09:53 -0700 > Cc: emacs-devel@gnu.org > > > > It's not important to "activate this thing by default" > > > (by which I assume you mean (w32-register-hot-key [M-tab])). > > > > > What is important is to _document_ it. > > > What were the objections raised to that? > > > > None. So go ahead, submit a patch. > > Attached. I'm no texi expert, so someone please check it. Thanks. I have a problem with this description: it doesn't really explain what can and what can't be an argument to these functions, and whether there's any significance to the term "hot-key" that is part of the functions' names. An example helps, but a single example is not enough to overcome the difficulty of a total lack of description of the argument, and also of what the function actually does. Come to think about it, the suggested text explains even less than the doc string does, which to me doesn't make sense (it should be the other way around). A few minor comments about the patch: > --- msdog-2008-05-27.texi 2008-05-27 08:25:12.000000000 -0700 > +++ msdog-patched-2008-05-27.texi 2008-05-27 09:07:40.000000000 -0700 Please have at least one of the two file names be the original file name (in this case, msdog.texi). Otherwise, the Patch utility will not be able to deduce the file to patch automatically, and will prompt whoever is applying to patch the manual, which is an annoyance. > +@vindex w32-register-hot-key > +@vindex w32-unregister-hot-key These should be @findex; @vindex is for variables/options. > + Although the @key{ALT} key is mapped by default to the Emacs > +@key{META} key, MS Windows preempts its use by Emacs for certain key > +combinations, such as @key{ALT-TAB}. You can use function > +@code{w32-register-hot-key} to allow a key sequence to be seen by > +Emacs instead of being grabbed by Windows. > + > +@kindex M-TAB @r{(MS-Windows)} > +@cindex @code{M-TAB} vs @code{Alt-TAB} (MS-Windows) You should use @kbd{M-@key{TAB}} and @kbd{Alt-@key{TAB}}, not @key{ALT-TAB} or @code{M-TAB}. > +@cindex @code{Alt-TAB} vs @code{M-TAB} (MS-Windows) > + For example, @code{(w32-register-hot-key [M-tab])} lets you use > +@kbd{M-TAB} normally in Emacs. This is effective at all levels, so, ^^ Two spaces after a period that ends a sentence, please. Finally, please include a ChangeLog entry with your patch. Thanks again.