From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Sat, 12 Mar 2005 02:11:23 +0000 Message-ID: References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> <010601c5269f$660e83d0$0200a8c0@sedrcw11488> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1110595095 20044 80.91.229.2 (12 Mar 2005 02:38:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2005 02:38:15 +0000 (UTC) Cc: hunterd42@comcast.net, Eli Zaretskii , kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 03:38:14 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D9wVz-0003wh-Mm for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 03:38:08 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9wlB-0006U8-LR for ged-emacs-devel@m.gmane.org; Fri, 11 Mar 2005 21:53:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D9wkK-0006A4-UF for emacs-devel@gnu.org; Fri, 11 Mar 2005 21:52:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D9whD-0004wc-Df for emacs-devel@gnu.org; Fri, 11 Mar 2005 21:49:44 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D9wgY-0004Zf-C7 for emacs-devel@gnu.org; Fri, 11 Mar 2005 21:49:03 -0500 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1D9w6P-0002gP-PD; Fri, 11 Mar 2005 21:11:42 -0500 Original-Received: from wanchan.jasonrumney.net (i-195-137-77-250.freedom2surf.net [195.137.77.250]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id j2C2BbnF026841; Sat, 12 Mar 2005 02:11:38 GMT Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 3E4F7DDFEE; Sat, 12 Mar 2005 02:11:35 +0000 (GMT) Original-To: "Lennart Borgman" In-Reply-To: <010601c5269f$660e83d0$0200a8c0@sedrcw11488> (Lennart Borgman's message of "Sat, 12 Mar 2005 02:03:45 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34501 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34501 "Lennart Borgman" writes: > I find it very hard to guess what this define is for without reading the > code. Using names like HAVE_MOUSE, HAVE_HOURGLASS makes it much more easy to > guess IMO. And I think that is important if you are scanning the code > quickly trying to find things, see the structure etc. Conditional compilation constants are not comments. They are not there to assist your reading of the code, they are there to enable that code when appropriate. For that purpose, it is actually clearer to have the constants named so that the conditions under which that code is enabled is obvious. Having hourglass code surrounded by HAVE_HOURGLASS is not adding anything, because the actual conditions under which hourglass cursors are available depend on the platform, not some configure test. Also someone debugging why hourglass cursors do not work on a Mac might miss the fact that they are only enabled on X and W32, that is not likely if we list the real conditions under which that code is enabled.