From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Diff mode faces Date: Fri, 17 Jun 2005 16:34:28 +0200 Message-ID: References: <87oea5urwm.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1119015188 31077 80.91.229.2 (17 Jun 2005 13:33:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Jun 2005 13:33:08 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 17 15:33:06 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DjGwK-0000dy-9s for ged-emacs-devel@m.gmane.org; Fri, 17 Jun 2005 15:31:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DjH1w-0005By-Nu for ged-emacs-devel@m.gmane.org; Fri, 17 Jun 2005 09:37:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DjH11-0004tk-LR for emacs-devel@gnu.org; Fri, 17 Jun 2005 09:36:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DjH0w-0004qJ-06 for emacs-devel@gnu.org; Fri, 17 Jun 2005 09:36:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DjH0v-0004pd-0O for emacs-devel@gnu.org; Fri, 17 Jun 2005 09:36:05 -0400 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DjH1T-0003eQ-IM for emacs-devel@gnu.org; Fri, 17 Jun 2005 09:36:39 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-47-229.inter.net.il [80.230.47.229]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id BOG15308 (AUTH halo1); Fri, 17 Jun 2005 16:34:34 +0300 (IDT) Original-To: Juri Linkov In-reply-to: <87oea5urwm.fsf@jurta.org> (message from Juri Linkov on Fri, 17 Jun 2005 14:47:05 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39014 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39014 > From: Juri Linkov > Date: Fri, 17 Jun 2005 14:47:05 +0300 > > The default diff face used to highlight changed lines on tty > (magenta/yellow bold italic) makes an indigestible fruit salad. In your opinion, perhaps. These faces are there since 5 years ago, and I don't recall anyone complaining. > OTOH, the same face has no highlighting under X. This makes > sense, because changed lines are the primary text in diff files > that doesn't need special highlighting. They need highlighting to stand out against the unchanged lines. Since most tty's don't have too many colors, they cannot make use of the technique similar to what we do on X, which is to dim the context lines by using light-grey colors for them. > I propose instead of highlighting whole lines on tty to use at least > the same approach as introduced recently for comments on tty to highlight > only comment delimiters in new face font-lock-comment-delimiter-face. > Similarly, only diff indicators (the first character of the line) could > be highlighted in diff buffers on tty. I don't think this is a good idea to make such a change. Certainly not now, before a release. Haven't we already seen enough trouble from this comment-delimiter face innovation? Anyway, the results look IMHO ugly. Partial highlighting of lines generally looks ugly, and this case is no exception. (I could never understand the urge to modify the default colors. If you dislike the defaults, customize the faces and be done with them.)