From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Scrollbar bugs in Windows port Date: Mon, 05 Jun 2006 22:26:57 +0100 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1149542981 26681 80.91.229.2 (5 Jun 2006 21:29:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Jun 2006 21:29:41 +0000 (UTC) Cc: Ralf Angeli , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 05 23:29:30 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FnMdT-0001cY-0q for ged-emacs-devel@m.gmane.org; Mon, 05 Jun 2006 23:29:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FnMdS-00078a-FS for ged-emacs-devel@m.gmane.org; Mon, 05 Jun 2006 17:29:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FnMd0-00073s-CN for emacs-devel@gnu.org; Mon, 05 Jun 2006 17:28:50 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FnMcy-00072U-10 for emacs-devel@gnu.org; Mon, 05 Jun 2006 17:28:49 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FnMcx-00072B-MO for emacs-devel@gnu.org; Mon, 05 Jun 2006 17:28:47 -0400 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FnMkA-0002Uv-HH; Mon, 05 Jun 2006 17:36:14 -0400 Original-Received: from wanchan.jasonrumney.net (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (Postfix) with ESMTP id BF75C6C11B3; Mon, 5 Jun 2006 22:28:44 +0100 (BST) Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id 68F0826A; Mon, 5 Jun 2006 22:28:44 +0100 (BST) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Mon, 05 Jun 2006 01:03:55 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55727 Archived-At: Eli Zaretskii writes: > I cannot reproduce the last one on my system; maybe it depends on the > details of the screen resolution. I will try to look into the other > two when I have time. I can reproduce all three, I think they are related - perhaps an off-by-one or rounding bug somewhere in the calculations that relate scrollbar position to buffer position and vice-versa. I have looked at this code several times in the past, but whenever I've made changes to fix one test case, something else has broken. I had another look now, and noticed that part of the confusion is caused by workarounds for obsolete versions of Windows NT that we haven't supported since at least Emacs 19.34. So I simplified the code for anyone who wants to look at it (in w32term.c, search for SCROLLINFO). I also noticed that there are a lot of places in the code that deal with scrolling, so perhaps the problem in the past is that only some of those got updated.