From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacsclient on WXP does not work (as it used to) Date: Fri, 31 Oct 2008 13:15:53 +0200 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1225451793 1084 80.91.229.12 (31 Oct 2008 11:16:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Oct 2008 11:16:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 31 12:17:26 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kvs09-0007eo-Vj for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2008 12:17:14 +0100 Original-Received: from localhost ([127.0.0.1]:55705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kvrz1-0002FU-W8 for ged-emacs-devel@m.gmane.org; Fri, 31 Oct 2008 07:16:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kvryw-0002EL-T2 for emacs-devel@gnu.org; Fri, 31 Oct 2008 07:15:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kvryv-0002E8-Dp for emacs-devel@gnu.org; Fri, 31 Oct 2008 07:15:58 -0400 Original-Received: from [199.232.76.173] (port=34583 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kvryv-0002E5-A6 for emacs-devel@gnu.org; Fri, 31 Oct 2008 07:15:57 -0400 Original-Received: from mtaout2.012.net.il ([84.95.2.4]:38353) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kvryu-0006ph-EV for emacs-devel@gnu.org; Fri, 31 Oct 2008 07:15:57 -0400 Original-Received: from HOME-C4E4A596F7 ([77.127.192.143]) by i_mtaout2.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K9L009B6OP7I710@i_mtaout2.012.net.il> for emacs-devel@gnu.org; Fri, 31 Oct 2008 13:17:32 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105188 Archived-At: > Date: Fri, 31 Oct 2008 12:02:12 +0100 > From: "Juanma Barranquero" > Cc: Emacs Devel > > Yes, this change: > > http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lib-src/emacsclient.c?r1=1.135&r2=1.136&pathrev=MAIN > > is wrong, because on Windows, once inside the if(), tty_name is always > going to be NULL. Can you please explain why is this a problem on Windows? I understand that the addition of current_frame to the `if' clause causes it to be entered on Windows, whereas it wasn't before, but how does that, and the fact that tty_name is NULL, cause emacsclient failure reported by dhruva? > I wonder why the whole if isn't just #ifdef'd out. Are there > legitimate uses of tty == 1 on Windows? > > The attached patch fixes the problem, but it's ugly as hell. Agreed (to the ``ugly'' part). I'd like to try to find a less ugly fix.