From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Diff mode faces Date: Mon, 20 Jun 2005 22:18:48 +0200 Message-ID: References: <87oea5urwm.fsf@jurta.org> <87psujj0h0.fsf@jurta.org> <86hdfv1y9b.fsf@blue.stonehenge.com> <87psuiqzcj.fsf@jurta.org> <87is09n00n.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1119295188 3257 80.91.229.2 (20 Jun 2005 19:19:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 20 Jun 2005 19:19:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 20 21:19:38 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DkRnh-0005wO-1l for ged-emacs-devel@m.gmane.org; Mon, 20 Jun 2005 21:19:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DkRtx-00014y-W2 for ged-emacs-devel@m.gmane.org; Mon, 20 Jun 2005 15:25:46 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DkRrq-0008SW-Vi for emacs-devel@gnu.org; Mon, 20 Jun 2005 15:23:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DkRrn-0008QL-3z for emacs-devel@gnu.org; Mon, 20 Jun 2005 15:23:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DkRrm-0008N2-Ho for emacs-devel@gnu.org; Mon, 20 Jun 2005 15:23:30 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DkRqE-0004Qc-PF for emacs-devel@gnu.org; Mon, 20 Jun 2005 15:21:55 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-44-230.inter.net.il [80.230.44.230]) by legolas.inter.net.il (MOS 3.5.8-GR) with ESMTP id ERB20050 (AUTH halo1); Mon, 20 Jun 2005 22:18:52 +0300 (IDT) Original-To: Juri Linkov In-reply-to: <87is09n00n.fsf@jurta.org> (message from Juri Linkov on Mon, 20 Jun 2005 07:48:08 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:39196 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:39196 > From: Juri Linkov > Date: Mon, 20 Jun 2005 07:48:08 +0300 > Cc: emacs-devel@gnu.org > > > First, it calls an obsolete function frame-update-face-colors (it's an > > alias for backward compatibility; let's use the function it is aliased > > to). > > Then it would be better to rename it in all C files to not create > Lisp symbols in C for both of them. Yes. > > Second, I think doing this unconditionally might not be a good idea: > > wouldn't it clash with what x_set_frame_parameters and > > IT_set_frame_parameters do for their respective displays? > > It is called conditionally on non-window and non-dos systems > so it doesn't clash with x_set_frame_parameters or IT_set_frame_parameters. Sorry, you are right. > I see there is a bug not caused by my patch: > > emacs -q -nw -rv > > sets the background mode to light on xterm. But since -rv switches > foreground and background, it should switch the background mode too > from light to dark on xterm. I think this is a bug. > > . modify the default color with set-background-color and verify that > > it is in effect for new frames created with "C-x 5 b" and the like > > For frames with undefined backgrounds it reuses the background mode > specified with set-background-color. Is it right? Yes, set-background-color is global, its effect is not limited to the frame where it was invoked. > update_face_from_frame_parameter at xfaces.c:4490 > x_set_background_color at xfns.c:911 > x_set_frame_parameters at frame.c:2738 > Fmodify_frame_parameters at frame.c:2280 > Finternal_set_lisp_face_attribute at xfaces.c:4434 > > But on tty it doesn't go past the function Fmodify_frame_parameters > due to the condition `if (FRAME_WINDOW_P (f))'. The explicit call > to `Qframe_update_face_colors' I added in Fmodify_frame_parameters > is on the else-branch of this condition. Thanks, I think this changed is okay.