From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ulrich Mueller Newsgroups: gmane.emacs.devel Subject: Re: emacsclient startup messages Date: Fri, 05 Nov 2021 10:40:48 +0100 Message-ID: References: <89dc096b-6c33-db5a-d2d2-b43fb92e4900@gmail.com> <074495a9-aff8-edce-f81f-51fdfc622f6e@gmail.com> <83bl2zdo4u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26454"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: jporterbugs@gmail.com, ulm@gentoo.org, Pedro Andres Aranda Gutierrez , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 05 10:42:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mivjd-0006kv-SO for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Nov 2021 10:42:09 +0100 Original-Received: from localhost ([::1]:54530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mivjc-0003Zm-R4 for ged-emacs-devel@m.gmane-mx.org; Fri, 05 Nov 2021 05:42:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1miviX-0002nJ-EQ for emacs-devel@gnu.org; Fri, 05 Nov 2021 05:41:01 -0400 Original-Received: from smtp.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4]:48099) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1miviU-0002gC-FZ; Fri, 05 Nov 2021 05:41:00 -0400 In-Reply-To: <83bl2zdo4u.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Nov 2021 10:04:33 +0200") Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:278753 Archived-At: >>>>> On Fri, 05 Nov 2021, Eli Zaretskii wrote: >> I have been applying the patch to my Ubuntu 20.04 builds for a couple >> of days and everything as worked well. Wouldn't it be a good time to >> put it into emacs-28? > Not yet. > Ulrich, any comments on this? Including its importance for Emacs 28? I've just tested with current master. The patch breaks the workflow used with Gentoo's app-emacs/emacs-daemon package. That is, a persistent Emacs daemon started with its socket in ${TMPDIR}/emacs${UID}/server, and emacsclient started with XDG_* variables in its environment: $ emacsclient -t --alternate-editor= emacsclient: can't find socket; have you started the server? emacsclient: To start the server in Emacs, type "M-x server-start". Another Emacs daemon is already running at process id 6084 Error: server did not start correctly Error: Could not start the Emacs daemon $ I haven't looked into the details of the code yet, but shouldn't the client first try to connect to an existing socket at both possible locations? And only start a new daemon when both attempts have failed?