unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Leake <stephen_leake@member.fsf.org>
Subject: Re: momentary-string-display
Date: Sat, 06 Jan 2007 02:36:13 -0500	[thread overview]
Message-ID: <ufyaofvyq.fsf@member.fsf.org> (raw)
In-Reply-To: <E1H31hV-0000Fv-PP@fencepost.gnu.org> (Richard Stallman's message of "Fri, 05 Jan 2007 21:54:29 -0500")

Richard Stallman <rms@gnu.org> writes:

> Does this patch fix that bug?

No, since the problem is the "move-to-window-line".

This fixes it; there may be a more elegant way:

Index: subr.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/subr.el,v
retrieving revision 1.542
diff -c -r1.542 subr.el
*** subr.el	5 Jan 2007 17:49:43 -0000	1.542
--- subr.el	6 Jan 2007 07:35:08 -0000
***************
*** 1905,1915 ****
  	      (recenter (/ (window-height) 2)))
  	  ;; If that pushed message start off the screen,
  	  ;; scroll to start it at the top of the screen.
! 	  (move-to-window-line 0)
! 	  (if (> (point) pos)
! 	      (progn
! 		(goto-char pos)
! 		(recenter 0)))
  	  (message (or message "Type %s to continue editing.")
  		   (single-key-description exit-char))
  	  (let (char)
--- 1905,1917 ----
  	      (recenter (/ (window-height) 2)))
  	  ;; If that pushed message start off the screen,
  	  ;; scroll to start it at the top of the screen.
!           (let ((start-pos (point)))
!             (move-to-window-line 0)
!             (if (> (point) pos)
!                 (progn
!                   (goto-char pos)
!                   (recenter 0))
!               (goto-char start-pos)))
  	  (message (or message "Type %s to continue editing.")
  		   (single-key-description exit-char))
  	  (let (char)

-- 
-- Stephe

  reply	other threads:[~2007-01-06  7:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-27  1:18 momentary-string-display Juanma Barranquero
2006-12-27 21:16 ` momentary-string-display Richard Stallman
2006-12-27 23:53   ` momentary-string-display Juanma Barranquero
2006-12-29 15:44     ` momentary-string-display Richard Stallman
2007-01-02 23:58       ` momentary-string-display Juanma Barranquero
2006-12-29  4:47   ` momentary-string-display Kevin Rodgers
2006-12-29 22:58     ` momentary-string-display Richard Stallman
2007-01-03  8:53       ` momentary-string-display Kevin Rodgers
2007-01-04  1:41         ` momentary-string-display Stephen Leake
2007-01-04  2:31         ` momentary-string-display Richard Stallman
2007-01-04 15:31           ` momentary-string-display Kevin Rodgers
2007-01-04 22:34             ` momentary-string-display Richard Stallman
2007-01-04 23:18               ` momentary-string-display Juanma Barranquero
2007-01-05 19:09                 ` momentary-string-display Richard Stallman
2007-01-05  7:05               ` momentary-string-display Stephen Leake
2007-01-06  2:54                 ` momentary-string-display Richard Stallman
2007-01-06  7:36                   ` Stephen Leake [this message]
2007-01-07  3:47                     ` momentary-string-display Richard Stallman
2007-01-07 14:41                       ` momentary-string-display Stephen Leake
2007-01-02 22:54   ` momentary-string-display Tak Ota
2007-01-03 21:11     ` momentary-string-display Richard Stallman
2007-01-03 21:36       ` momentary-string-display Tak Ota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ufyaofvyq.fsf@member.fsf.org \
    --to=stephen_leake@member.fsf.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).