Re: Preprocessor defines in MS-Windows build

[Eli Zaretskii <eliz@gnu.org>]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 07 Jun 2008 15:04:21 -0400
> 
> > these are not needed, and almost all the rest can be put on
> > src/s/ms-w32.h.
> 
> Ideally src/config.h, no (tho maybe it's more difficult)?

You mean, nt/config.nt (that is copied into src/config.h), right?

Why is that better, btw?

> Look at admin/CPP-DEFINES as well (and update/improve it whenever
> possible, of course).

I already did.  It doesn't say anything helpful about the defines I
listed, and doesn't have any additional ones.

> >  HAVE_NTGUI          -- can be replaced with WINDOWSNT, since the W32
> >                         build doesn't use any other GUI
> 
> Don't we support W32 builds without GUI?

No, not AFAIK.  The produced binary can be run with the -nw switch,
but it has GUI support built in.

> > Does someone know anything that contradicts the above?  If not, I
> > think we should remove those defines that are not needed anymore, and
> > put those which are needed in ms-w32.h.
> 
> Sounds fine to me,

Thanks for the feedback.