From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Testing window-system considered harmful
Date: Fri, 21 Oct 2005 16:50:36 +0200 [thread overview]
Message-ID: <uek6eq5z7.fsf@gnu.org> (raw)
In-Reply-To: <E1ESvR4-0001vc-4g@monty-python.gnu.org> (emacs-diffs-request@gnu.org)
Re: this change:
> From: emacs-diffs-request@gnu.org
> Date: Fri, 21 Oct 2005 07:51:47 -0400
>
> Date: Fri, 21 Oct 2005 04:26:37 -0400
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Subject: [Emacs-diffs] Changes to emacs/lisp/cus-face.el
> To: emacs-diffs@gnu.org
> Message-ID: <E1ESsEX-0002DE-00@savannah.gnu.org>
>
> Index: emacs/lisp/cus-face.el
> diff -c emacs/lisp/cus-face.el:1.41 emacs/lisp/cus-face.el:1.42
> *** emacs/lisp/cus-face.el:1.41 Sat Aug 6 22:13:42 2005
> --- emacs/lisp/cus-face.el Fri Oct 21 08:26:37 2005
> ***************
> *** 47,53 ****
> (dolist (frame (frame-list))
> (face-spec-set face value frame)))
> ;; When making a face after frames already exist
> ! (if (memq window-system '(x w32))
> (make-face-x-resource-internal face))))
> ;; Don't record SPEC until we see it causes no errors.
> (put face 'face-defface-spec spec)
> --- 47,53 ----
> (dolist (frame (frame-list))
> (face-spec-set face value frame)))
> ;; When making a face after frames already exist
> ! (if (memq window-system '(x w32 mac))
> (make-face-x-resource-internal face))))
> ;; Don't record SPEC until we see it causes no errors.
> (put face 'face-defface-spec spec)
Is it possible to use one of the display-*-p predicate functions
instead of testing the value of window-system here? It is always
better to use one of those predicates, because they automatically
support all relevant Emacs configurations, without any need to add
them explicitly to a list such as the one above.
(There are other changes like the one above that used window-system;
please consider them all.)
next parent reply other threads:[~2005-10-21 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1ESvR4-0001vc-4g@monty-python.gnu.org>
2005-10-21 14:50 ` Eli Zaretskii [this message]
2005-10-24 1:09 ` Testing window-system considered harmful YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uek6eq5z7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).