From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar buttons unresponsive with tooltips on Date: Sun, 23 Oct 2005 22:54:45 +0100 Message-ID: References: <29911216.1129711174895.JavaMail.www@wwinf0202> <4356830F.3000002@swipnet.se> <6752BDE2-0EF5-47FF-BB01-F9050E7A4026@swipnet.se> <87k6g9unq8.fsf_-_@stupidchicken.com> <873bmwutz3.fsf@stupidchicken.com> <435BFD2B.3000705@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1130104756 5874 80.91.229.2 (23 Oct 2005 21:59:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2005 21:59:16 +0000 (UTC) Cc: Chong Yidong , "Kim F. Storm" , Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 23 23:59:14 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ETnqJ-00062B-5J for ged-emacs-devel@m.gmane.org; Sun, 23 Oct 2005 23:57:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ETnqH-0004c0-2c for ged-emacs-devel@m.gmane.org; Sun, 23 Oct 2005 17:57:25 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ETnpE-00046z-42 for emacs-devel@gnu.org; Sun, 23 Oct 2005 17:56:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ETnpC-00046b-GC for emacs-devel@gnu.org; Sun, 23 Oct 2005 17:56:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ETnpC-00046Y-9E for emacs-devel@gnu.org; Sun, 23 Oct 2005 17:56:18 -0400 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1ETnpC-0006Tk-80 for emacs-devel@gnu.org; Sun, 23 Oct 2005 17:56:18 -0400 Original-Received: from wanchan.jasonrumney.net (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (8.12.10/8.12.10) with ESMTP id j9NLuEch002139; Sun, 23 Oct 2005 22:56:14 +0100 Original-Received: from TONKOTSU-RAMEN (tonkotsu-ramen.jasonrumney.net [10.0.0.28]) by wanchan.jasonrumney.net (Postfix) with ESMTP id BCEB8438; Sun, 23 Oct 2005 22:56:13 +0100 (BST) Original-To: "Jan D." In-Reply-To: <435BFD2B.3000705@swipnet.se> (Jan D.'s message of "Sun, 23 Oct 2005 23:14:19 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:44647 Archived-At: "Jan D." writes: > I've checked in this change. I hope it doesn't ruin the intent of > calling remember_mouse_glyph in the first place. The if statement is clearly trying to avoid calling note_mouse_highlight for every pixel of mouse movement, since that was the only substantial code inside the if statement originally. Moving note_mouse_highlight outside the if block is certainly ruining the intent of that code. I don't understand what note_mouse_highlight has to do with being able to click the mouse on a toolbar button. I think if you can find the reason why note_mouse_highlight affects that, you will be led to the real bug.