view-lossage hard-codes 100 keystrokes

view-lossage hard-codes 100 keystrokes

[Drew Adams]

Any chance that the number of keystrokes displayed by `view-lossage',
currently hard-coded at 100, could be made a user option?

Re: view-lossage hard-codes 100 keystrokes

[Eli Zaretskii]

> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Thu, 23 Mar 2006 13:26:05 -0800
> 
> Any chance that the number of keystrokes displayed by `view-lossage',
> currently hard-coded at 100, could be made a user option?

It's not easily done, since the keys are recorded in a statically
allocated C array whose size is a compile-time constant.  I won't
recommend such a change for before the release, but that's just me.

Re: view-lossage hard-codes 100 keystrokes

[Kim F. Storm]

Eli Zaretskii <eliz@gnu.org> writes:

> It's not easily done, since the keys are recorded in a statically
> allocated C array whose size is a compile-time constant. 

Actually, it is recorded in a Lisp Vector, so it should be
trivial to increase the size of that vector.

We could add the size of the lossage buffer as a second
arg to clear-this-command-keys which already interfaces
to the recent keys vector.

> I won't
> recommend such a change for before the release, but that's just me.

I don't see an urgent need, but it would be a trivial change.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

RE: view-lossage hard-codes 100 keystrokes

[Drew Adams]

    > It's not easily done, since the keys are recorded in a statically
    > allocated C array whose size is a compile-time constant.

    Actually, it is recorded in a Lisp Vector, so it should be
    trivial to increase the size of that vector.

    We could add the size of the lossage buffer as a second
    arg to clear-this-command-keys which already interfaces
    to the recent keys vector.

    > I won't
    > recommend such a change for before the release, but that's just me.

    I don't see an urgent need, but it would be a trivial change.

No, nothing urgent or even very important. If it could be done, I think it
would be helpful. Even increasing 100 to, say 500 or 1000 would be helpful.

For some reason, I find that on the rare occasions that I need to use this,
what I'm looking for is often further back than 100 keystrokes.

Re: view-lossage hard-codes 100 keystrokes

[Richard Stallman]

    Any chance that the number of keystrokes displayed by `view-lossage',
    currently hard-coded at 100, could be made a user option?

I would not mind if this were done, but it should be after the release.

Re: view-lossage hard-codes 100 keystrokes

[Richard Stallman]

    > I won't
    > recommend such a change for before the release, but that's just me.

    I don't see an urgent need, but it would be a trivial change.

I am glad it is so simple.  I'd still rather save it for after the
release, but at that time, please make the change.