From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bug in incremental undrawing of mouseover highlighting Date: Thu, 23 Nov 2006 00:20:04 +0200 Message-ID: References: <17760.56196.739515.442009@rgrjr.dyndns.org> <87zmaludmg.fsf@cyd.mit.edu> <87u00ro6yc.fsf@cyd.mit.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1164234049 17341 80.91.229.2 (22 Nov 2006 22:20:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2006 22:20:49 +0000 (UTC) Cc: rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 22 23:20:48 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gn0SV-0007JO-Oz for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2006 23:20:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn0SV-0004Uo-8B for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2006 17:20:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gn0Rk-00046g-7E for emacs-devel@gnu.org; Wed, 22 Nov 2006 17:20:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gn0Ri-000458-Nx for emacs-devel@gnu.org; Wed, 22 Nov 2006 17:19:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gn0Ri-00044z-JK for emacs-devel@gnu.org; Wed, 22 Nov 2006 17:19:58 -0500 Original-Received: from [192.114.186.73] (helo=heller.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gn0Ri-0000QK-3b for emacs-devel@gnu.org; Wed, 22 Nov 2006 17:19:58 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-84-229-208-204.inter.net.il [84.229.208.204]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id BBL07335 (AUTH halo1); Thu, 23 Nov 2006 00:19:56 +0200 (IST) Original-To: Chong Yidong In-reply-to: <87u00ro6yc.fsf@cyd.mit.edu> (message from Chong Yidong on Wed, 22 Nov 2006 10:07:55 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62700 Archived-At: > Cc: rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org > From: Chong Yidong > Date: Wed, 22 Nov 2006 10:07:55 -0500 > > Eli Zaretskii writes: > > >> + #ifdef HAVE_WINDOW_SYSTEM > >> + if (dpyinfo && EQ (window, dpyinfo->mouse_face_window)) > >> + clear_mouse_face (dpyinfo); > >> + #endif > >> + > > > > Are these #ifdef's really right? The mouse highlight is supported not > > only in builds that define HAVE_WINDOW_SYSTEM. > > note_mouse_highlight is only defined inside HAVE_WINDOW_SYSTEM. That's true, but you weren't modifying note_mouse_highlight, you referenced dpyinfo->mouse_face_window. You will see that at least src/msdos.c manipulates dpyinfo->mouse_face_window. The MSDOS build supports mouse highlight, but does not define HAVE_WINDOW_SYSTEM, and set_window_buffer, where you suggested to make the change, is compiled into the MSDOS port.