From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Fri, 18 May 2007 17:33:27 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> <17995.53754.860573.633945@kahikatea.snap.net.nz> <17996.55425.495501.592760@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179498820 11242 80.91.229.12 (18 May 2007 14:33:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 18 May 2007 14:33:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 18 16:33:39 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hp3WS-00047f-6a for ged-emacs-devel@m.gmane.org; Fri, 18 May 2007 16:33:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hp3ef-0006nL-BS for ged-emacs-devel@m.gmane.org; Fri, 18 May 2007 10:42:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hp3ec-0006mx-2W for emacs-devel@gnu.org; Fri, 18 May 2007 10:42:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hp3ea-0006mM-Hf for emacs-devel@gnu.org; Fri, 18 May 2007 10:42:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hp3ea-0006mJ-Ev for emacs-devel@gnu.org; Fri, 18 May 2007 10:42:00 -0400 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hp3WM-0006si-Aj for emacs-devel@gnu.org; Fri, 18 May 2007 10:33:30 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-84-229-224-83.inter.net.il [84.229.224.83]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id CPP51131 (AUTH halo1); Fri, 18 May 2007 17:33:26 +0300 (IDT) In-reply-to: <17996.55425.495501.592760@kahikatea.snap.net.nz> (message from Nick Roberts on Fri, 18 May 2007 10:34:41 +1200) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71314 Archived-At: > From: Nick Roberts > Date: Fri, 18 May 2007 10:34:41 +1200 > Cc: emacs-devel@gnu.org > > > I suggested an alternative a few days ago: to add a new function, say, > > write_mouse_highlighted_glyphs, which does the same as write_glyphs, > > but uses the mouse face. You could then call this function in the > > only place where you now need write_glyphs to use the mouse face. > > Would this solve the problem without any unnecessary overhead? > > That's another possibility, but it results in duplication of code (write_glyphs > is about 80 lines long) which adds to the burden of maintenance. I don't think the burden is too big: write_glyphs is not a large function, and insert_glyphs already uses this technique anyway. > I think each approach has pros and cons; it's just a matter of choosing one. I prefer the separate function approach.