From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Reviewing changes Date: Fri, 21 Nov 2008 17:14:54 +0200 Message-ID: References: <87y6zggnmz.fsf@red-bean.com> <87d4grbcc0.fsf@red-bean.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1227280526 7660 80.91.229.12 (21 Nov 2008 15:15:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Nov 2008 15:15:26 +0000 (UTC) Cc: kfogel@red-bean.com, cyd@stupidchicken.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 21 16:16:27 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L3Xjx-00033Z-OS for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 16:16:14 +0100 Original-Received: from localhost ([127.0.0.1]:35447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3Xio-0005lY-4N for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 10:15:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L3Xij-0005l9-UG for emacs-devel@gnu.org; Fri, 21 Nov 2008 10:14:57 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L3Xii-0005kp-GP for emacs-devel@gnu.org; Fri, 21 Nov 2008 10:14:57 -0500 Original-Received: from [199.232.76.173] (port=38323 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L3Xii-0005km-BV for emacs-devel@gnu.org; Fri, 21 Nov 2008 10:14:56 -0500 Original-Received: from mtaout1.012.net.il ([84.95.2.1]:32029) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L3Xii-0004vq-7y for emacs-devel@gnu.org; Fri, 21 Nov 2008 10:14:56 -0500 Original-Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KAO00E00VRC6K00@i-mtaout1.012.net.il> for emacs-devel@gnu.org; Fri, 21 Nov 2008 17:16:54 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.14.29]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KAO007EAVS50K20@i-mtaout1.012.net.il>; Fri, 21 Nov 2008 17:16:54 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105892 Archived-At: > From: Stefan Monnier > Cc: kfogel@red-bean.com, cyd@stupidchicken.com, emacs-devel@gnu.org > Date: Fri, 21 Nov 2008 09:32:28 -0500 > > >> So you object to naming them "code reviews"? That's OK, let's call them > >> "random comments", then. > >> I just can't see how encouraging such random comments can hurt. > > > I didn't say it will hurt. I said it won't help us make the code > > quality better, which I assumed what this was all about. Sounds like > > my assumption was wrong. > > No, this was all about asking to change the format of the email sent to > emacs-diffs and emacs-commit so that they'd contain both the changelog > and the diffs (hopefully of all the files modified by the given > commit) together. > Karl mentioned he'd prefer it, and also added that it would make > reviewing easier. Karl _asked_ for it, and he said he was asking _because_ it will make reviewing easier. > Your argumentation seemed to say that you disagreed with such a change > specifically because it would make people start to do such > pseudo-reviewing which is worse than not doing reviewing at all. I don't think I wrote anything that could be read like this. In particular, I don't think I ever said I disagreed with the change.