From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [drew.adams@oracle.com: links in Help buffer aren'talwayscorrect] Date: Fri, 23 Dec 2005 19:47:26 +0200 Message-ID: References: <20051219192208.31866.qmail@web51011.mail.yahoo.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1135360071 22288 80.91.229.2 (23 Dec 2005 17:47:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2005 17:47:51 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 23 18:47:48 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Epr14-00050U-PB for ged-emacs-devel@m.gmane.org; Fri, 23 Dec 2005 18:47:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epr28-0007de-GC for ged-emacs-devel@m.gmane.org; Fri, 23 Dec 2005 12:48:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Epr1v-0007b3-S1 for emacs-devel@gnu.org; Fri, 23 Dec 2005 12:48:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Epr1u-0007Ym-6I for emacs-devel@gnu.org; Fri, 23 Dec 2005 12:48:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epr1u-0007Ya-2H for emacs-devel@gnu.org; Fri, 23 Dec 2005 12:48:34 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Epr1E-0005GL-EP for emacs-devel@gnu.org; Fri, 23 Dec 2005 12:47:52 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-201-187.inter.net.il [83.130.201.187]) by romy.inter.net.il (MOS 3.7.2-GA) with ESMTP id DFP14044 (AUTH halo1); Fri, 23 Dec 2005 19:47:24 +0200 (IST) Original-To: Kevin Rodgers In-reply-to: (message from Kevin Rodgers on Fri, 23 Dec 2005 10:07:02 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48255 Archived-At: > From: Kevin Rodgers > Date: Fri, 23 Dec 2005 10:07:02 -0700 > > Another small simplification: > > > (xref-or-indent-regexp > > (format "\\(%s\\)\\|\\(\n +\\)" xref-regexp)) > ... > > (while (re-search-forward xref-or-indent-regexp > nil t) > > (cond ((and (match-beginning 1) (match-end 1)) > > (replace-match "" t t)) > > ((and (match-beginning 2) (match-end 2)) > > (replace-match "\n" t t)))) > > could be: > > (xref-or-indent-regexp > (concat xref-regexp "\\|^ +")) > ... > (while (re-search-forward xref-or-indent-regexp nil t) > (replace-match "" t t) Could you please send "diff -c" or "diff -u" style patches instead? It is a PITA to apply such changes by hand, and on top of that, manual patching runs a greater risk of introducing bugs. TIA