From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Mon, 28 Nov 2005 07:32:32 +0200 Message-ID: References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <069BF3EB-C5E4-4042-91E9-0DFB37C58E99@gmail.com> <36F6CF11-E742-4175-A995-E5A62EC2A335@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1133156257 7630 80.91.229.2 (28 Nov 2005 05:37:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 28 Nov 2005 05:37:37 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 28 06:37:29 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EgbdL-00063e-Dp for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2005 06:33:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EgbdK-0008D2-Qb for ged-emacs-devel@m.gmane.org; Mon, 28 Nov 2005 00:32:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EgbdA-0008Ck-TO for emacs-devel@gnu.org; Mon, 28 Nov 2005 00:32:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Egbd9-0008CY-1O for emacs-devel@gnu.org; Mon, 28 Nov 2005 00:32:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Egbd8-0008CV-UZ for emacs-devel@gnu.org; Mon, 28 Nov 2005 00:32:46 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Egbd8-00048W-Jv for emacs-devel@gnu.org; Mon, 28 Nov 2005 00:32:46 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-11-213.inter.net.il [80.230.11.213]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id DBL12589 (AUTH halo1); Mon, 28 Nov 2005 07:32:26 +0200 (IST) Original-To: David Reitter In-reply-to: <36F6CF11-E742-4175-A995-E5A62EC2A335@gmail.com> (message from David Reitter on Mon, 28 Nov 2005 00:21:58 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:46691 Archived-At: > Cc: rms@gnu.org, > emacs-devel@gnu.org > From: David Reitter > Date: Mon, 28 Nov 2005 00:21:58 +0000 > > On 12 Nov 2005, at 07:11, Eli Zaretskii wrote: > > > No, please DON'T!! We currently don't have a good way of checking > > whether the menu's frame is visible. The code used by David to do > > that does not work in non-toolkit builds of Emacs (see another thread > > where Juri about this), so installing it will disable many important > > menu items in non-toolkit X builds. > > > > I suggest to wait with the patch until that other problem is resolved. > > Do you know if this problem (with menu-bar-menu-frame-live-and- > visible-p I presume) has been solved now? No, not yet. > I didn't bother writing a workaround for this issue because I thought > the original bug would be fixed sooner or later. I'm not sure it's a bug, it could be a missing feature. The issue is how to determine that a frame that displays the current menu is visible. The code we are discussing tries to use menu-updating-frame, but it looks like that variable is not a reliable way of finding the frame in question at the point where we need it (which is when a menu is dropped after a mouse click). Perhaps someone could suggest a better way of finding the menu's frame.