From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: menu-bar: disable items when no frame visible Date: Fri, 16 Dec 2005 13:29:05 +0200 Message-ID: References: <708F3D2D-A87C-4F80-BC27-171D82653F4D@gmail.com> <069BF3EB-C5E4-4042-91E9-0DFB37C58E99@gmail.com> <36F6CF11-E742-4175-A995-E5A62EC2A335@gmail.com> <87psobhwo5.fsf@jurta.org> <87u0dl3gpy.fsf@jurta.org> <439D3397.1020404@swipnet.se> <439E75F8.4050201@swipnet.se> <877ja71vyq.fsf@jurta.org> <87irtpbata.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1134745071 26058 80.91.229.2 (16 Dec 2005 14:57:51 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 16 Dec 2005 14:57:51 +0000 (UTC) Cc: david.reitter@gmail.com, jan.h.d@swipnet.se, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 16 15:57:48 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EnH0v-0007ei-Ce for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 15:56:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnH1c-0003fF-0L for ged-emacs-devel@m.gmane.org; Fri, 16 Dec 2005 09:57:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EnEcx-0007G7-R3 for emacs-devel@gnu.org; Fri, 16 Dec 2005 07:24:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EnEX2-0006P8-MA for emacs-devel@gnu.org; Fri, 16 Dec 2005 07:18:01 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EnDmi-0003pn-8Z for emacs-devel@gnu.org; Fri, 16 Dec 2005 06:30:02 -0500 Original-Received: from [192.114.186.17] (helo=gandalf.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EnDp7-00013P-Gy for emacs-devel@gnu.org; Fri, 16 Dec 2005 06:32:29 -0500 Original-Received: from nitzan.inter.net.il (nitzan.inter.net.il [192.114.186.20]) by gandalf.inter.net.il (MOS 3.7.1-GA) with ESMTP id HGY15421; Fri, 16 Dec 2005 13:29:06 +0200 (IST) Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-246-163.inter.net.il [83.130.246.163]) by nitzan.inter.net.il (MOS 3.7.2-GA) with ESMTP id CFU04887 (AUTH halo1); Fri, 16 Dec 2005 13:29:04 +0200 (IST) Original-To: Juri Linkov In-reply-to: <87irtpbata.fsf@jurta.org> (message from Juri Linkov on Fri, 16 Dec 2005 11:04:59 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:47855 Archived-At: > From: Juri Linkov > Cc: jan.h.d@swipnet.se, david.reitter@gmail.com, emacs-devel@gnu.org > Date: Fri, 16 Dec 2005 11:04:59 +0200 > > Below is a fix that sets menu-updating-frame correctly for three > platforms (X, Mac, W32), and also doesn't disable menu items > permanently on tty and non-toolkit X builds: If you fixed the code to set menu-updating-frame correctly for all platforms, then why did you need to change menu-bar.el as well? I mean changes like this one: > *** lisp/menu-bar.el 13 Dec 2005 11:07:50 -0000 1.284 > --- lisp/menu-bar.el 16 Dec 2005 09:02:43 -0000 > *************** > *** 1418,1425 **** > (defun menu-bar-menu-frame-live-and-visible-p () > "Return non-nil if the menu frame is alive and visible. > The menu frame is the frame for which we are updating the menu." > ! (let ((menu-frame (if (display-multi-frame-p) menu-updating-frame > ! (selected-frame)))) > (and (frame-live-p menu-frame) > (frame-visible-p menu-frame)))) > > --- 1418,1424 ---- > (defun menu-bar-menu-frame-live-and-visible-p () > "Return non-nil if the menu frame is alive and visible. > The menu frame is the frame for which we are updating the menu." > ! (let ((menu-frame (or menu-updating-frame (selected-frame)))) > (and (frame-live-p menu-frame) > (frame-visible-p menu-frame)))) > > ***************